db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kristian Waagan (JIRA)" <j...@apache.org>
Subject [jira] Commented: (DERBY-2646) Cleanup of Clob control/support structures
Date Mon, 21 May 2007 15:25:16 GMT

    [ https://issues.apache.org/jira/browse/DERBY-2646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12497486

Kristian Waagan commented on DERBY-2646:

I'm planning to do a review and cleanup of the underlying structures of Clob in the embedded
driver. I foresee that ClobStreamControl and maybe EmbedClob will be affected by this, but
some other classes might have to be changed as well.

My current plans:
 1) Write a new test for Clob.
    Only methods defined by JDBC 3 or earlier will be tested. Currently these tests reside
in jdbcapi/ClobTest.java (in my sandbox), but there is already a ClobTest in the jdbc4 package.
I would prefer to rename the jdbc4 one to something else. Any opinions on this?

 2) Review and rewrite ClobStreamControl as appropriate.
    I will focus especially on getting the byte and clob positions right, as it has been suggested
these have been mixed up on occasions. Changes might propagate to EmbedClob, but I hope the
changes there will be minimal.

Preliminary findings:
When executing the new tests, I quickly got tangled up in the current difference of behavior
between the embedded and the client driver for setBytes etc. I do not plan to work on these,
as I understand other work going on at the moment will fix these issues when the switch to
locators is made effective.
I also see differences in handling of the "ASCII" encoding, probably related to the client
using US-ASCII and embedded ISO-8859-1. I believe the latter is the correct one, and that
enabling locators might resolve the issues.
Last, I see an UTFDataFormat exception when inserting some Norwegian characters with setAsciiStream.

If people have comments, questions or additions to my little plan, please let me know.
I do plan to get this issue done for 10.3.

> Cleanup of Clob control/support structures
> ------------------------------------------
>                 Key: DERBY-2646
>                 URL: https://issues.apache.org/jira/browse/DERBY-2646
>             Project: Derby
>          Issue Type: Sub-task
>          Components: JDBC
>    Affects Versions:
>            Reporter: Kristian Waagan
>         Assigned To: Kristian Waagan
>         Attachments: derby-2646-01a_trailing_space.diff, derby-2646-01a_trailing_space.stat

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message