Return-Path: Delivered-To: apmail-db-derby-dev-archive@www.apache.org Received: (qmail 63616 invoked from network); 4 Apr 2007 20:41:30 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 4 Apr 2007 20:41:30 -0000 Received: (qmail 30952 invoked by uid 500); 4 Apr 2007 20:41:36 -0000 Delivered-To: apmail-db-derby-dev-archive@db.apache.org Received: (qmail 30917 invoked by uid 500); 4 Apr 2007 20:41:36 -0000 Mailing-List: contact derby-dev-help@db.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: Delivered-To: mailing list derby-dev@db.apache.org Received: (qmail 30908 invoked by uid 99); 4 Apr 2007 20:41:36 -0000 Received: from herse.apache.org (HELO herse.apache.org) (140.211.11.133) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 04 Apr 2007 13:41:36 -0700 X-ASF-Spam-Status: No, hits=2.0 required=10.0 tests=HTML_MESSAGE,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (herse.apache.org: domain of msatoor@gmail.com designates 209.85.132.243 as permitted sender) Received: from [209.85.132.243] (HELO an-out-0708.google.com) (209.85.132.243) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 04 Apr 2007 13:41:28 -0700 Received: by an-out-0708.google.com with SMTP id c25so399761ana for ; Wed, 04 Apr 2007 13:41:08 -0700 (PDT) DKIM-Signature: a=rsa-sha1; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:references; b=ABc/4Is4cmn0cbEvNdZTuOuTfa8Fdy06KUK4wHQwAwf4sjT6kQg/1LmBJsm37onh01AMxYfpT56FjKXxMAZCEgmH2RKk2xwv/eHifNs5BPTgAZaPMpN/8z9j35VBz8wZox6mDMU0uXqWxHcBfwR4vxc5WnW4kZbfZsC2cuqVLjs= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:references; b=GDB2nOeHGRU/OIn3XL91I3SvjONOtxKx5/FEkIS7IWG9y0ZEh83N9qNGlf6RuESRDk3T2w4U+ih3Id3sngBTM4o9HzV7HuWSEEm77esnd81n+Xeczf+Jh0Z777xBC/4EPAiILGqaPWiYODZxkq90fCQPLRwV6XzmFGmMJ70sI2k= Received: by 10.100.43.9 with SMTP id q9mr766918anq.1175719267663; Wed, 04 Apr 2007 13:41:07 -0700 (PDT) Received: by 10.100.136.4 with HTTP; Wed, 4 Apr 2007 13:41:07 -0700 (PDT) Message-ID: Date: Wed, 4 Apr 2007 13:41:07 -0700 From: "Mamta Satoor" To: derby-dev@db.apache.org Subject: Re: [jira] Updated: (DERBY-2524) DataTypeDescriptor(DTD) needs to have collation type and collation derivation. These new fields will apply only for character string types. Other types should ignore them. In-Reply-To: <4613F3FE.8030704@apache.org> MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="----=_Part_38408_8527420.1175719267544" References: <6764026.1175710952245.JavaMail.jira@brutus> <4613F3FE.8030704@apache.org> X-Virus-Checked: Checked by ClamAV on apache.org ------=_Part_38408_8527420.1175719267544 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline Copied from Dan's mail ************************************************************* > 2)Is it right to assume that readExternal and writeExternal methods in > TypeDescriptorImpl will get called only for persistent columns? Probably, though looking forward at some point the derivation will need to be stored, might be worth thinking about this now to avoid future upgrades. ************************************************************* I wonder if precision field is available for character string types. If it is available, then we can possibly use it to store collation derivation (I will convert collation derivation to int in my followup patch) for character string types. Mamta On 4/4/07, Daniel John Debrunner wrote: > > Mamta A. Satoor (JIRA) wrote: > > > > Questions > > 1)I have included all the constant definitions related to collation in > TypeDescriptor. > > If anyone has suggestion on a better place to define them, let me know. > > I'd thought about defining such constants on StringDataValue since they > only apply to character types. > > Why string constants for derivation though, why not integer values? > Also there's no constant for error, though I would not recommend having > an error value. Why not just use none as the default value? That will > lead to the same behaviour, no collation suppported. Adding an error > state is something that is not in the SQL standard. > > Note that the javadoc comments you added for these constants are only > for the first constant, the others will have no javadoc. > > > 2)Is it right to assume that readExternal and writeExternal methods in > > TypeDescriptorImpl will get called only for persistent columns? > > Probably, though looking forward at some point the derivation will need > to be stored, might be worth thinking about this now to avoid future > upgrades. > > Dan. > > > > ------=_Part_38408_8527420.1175719267544 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline
Copied from Dan's mail
*************************************************************
> 2)Is it right to assume that readExternal and writeExternal methods in
> TypeDescriptorImpl will get called only for persistent columns?

 
Probably, though looking forward at some point the derivation will need
to be stored, might be worth thinking about this now to avoid future
upgrades.
 
*************************************************************
I wonder if precision field is available for character string types. If it is available, then we can possibly use it to store collation derivation (I will convert collation derivation to int in my followup patch) for character string types.
 
Mamta


 
On 4/4/07, Daniel John Debrunner <djd@apache.org> wrote:
Mamta A. Satoor (JIRA) wrote:


> Questions
> 1)I have included all the constant definitions related to collation in TypeDescriptor.
> If anyone has suggestion on a better place to define them, let me know.

I'd thought about defining such constants on StringDataValue since they
only apply to character types.

Why string constants for derivation though, why not integer values?
Also there's no constant for error, though I would not recommend having
an error value. Why not just use none as the default value? That will
lead to the same behaviour, no collation suppported. Adding an error
state is something that is not in the SQL standard.

Note that the javadoc comments you added for these constants are only
for the first constant, the others will have no javadoc.

> 2)Is it right to assume that readExternal and writeExternal methods in
> TypeDescriptorImpl will get called only for persistent columns?

Probably, though looking forward at some point the derivation will need
to be stored, might be worth thinking about this now to avoid future
upgrades.

Dan.




------=_Part_38408_8527420.1175719267544--