From derby-dev-return-40543-apmail-db-derby-dev-archive=db.apache.org@db.apache.org Mon Apr 16 10:07:39 2007 Return-Path: Delivered-To: apmail-db-derby-dev-archive@www.apache.org Received: (qmail 47806 invoked from network); 16 Apr 2007 10:07:37 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 16 Apr 2007 10:07:37 -0000 Received: (qmail 66947 invoked by uid 500); 16 Apr 2007 10:07:43 -0000 Delivered-To: apmail-db-derby-dev-archive@db.apache.org Received: (qmail 66837 invoked by uid 500); 16 Apr 2007 10:07:42 -0000 Mailing-List: contact derby-dev-help@db.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: Delivered-To: mailing list derby-dev@db.apache.org Received: (qmail 66822 invoked by uid 99); 16 Apr 2007 10:07:42 -0000 Received: from herse.apache.org (HELO herse.apache.org) (140.211.11.133) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 16 Apr 2007 03:07:42 -0700 X-ASF-Spam-Status: No, hits=-100.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO brutus.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 16 Apr 2007 03:07:35 -0700 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 81668714057 for ; Mon, 16 Apr 2007 03:07:15 -0700 (PDT) Message-ID: <32450888.1176718035527.JavaMail.jira@brutus> Date: Mon, 16 Apr 2007 03:07:15 -0700 (PDT) From: "Kristian Waagan (JIRA)" To: derby-dev@db.apache.org Subject: [jira] Updated: (DERBY-2495) Create framework for calling locator related stored procedures from client In-Reply-To: <13963871.1175081072184.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/DERBY-2495?page=3Dcom.atlassia= n.jira.plugin.system.issuetabpanels:all-tabpanel ] Kristian Waagan updated DERBY-2495: ----------------------------------- Derby Info: (was: [Patch Available]) Committed 'blobframework_v2.diff' to trunk with revision 529185. Very nicely commented patch =C3=98ystein! I reviewed the patch and have the following suggestions/comments for a foll= owup patch: 1) Would a comment that all the new set-/getX methods use 1-based indexes = be helpful? 2) Invalid @see tag in CallableLocatorProcedures (class JavaDoc). 3) Any reason why CallableLocatorProcedures.connection isn't final? 4) Can you get the value of VARCHAR_MAXWIDTH from somewhere, or use an exi= sting constant? I would also make it private to signal that it is not supposed to be us= ed outside this class (I seem to recall that it is defined in another class= already). 5) CallableLocatorProcedures.blobTruncate could add newlines around the pa= ragraph tag. 6) Why use new String("") in CallableLocatorProcedures.clobGetSubString? The methods using repeated procedure calls for large values is a bit tricky= , so I hope there will be some (boundary) tests in place when the code is e= nabled. Thanks, > Create framework for calling locator related stored procedures from clien= t > -------------------------------------------------------------------------= - > > Key: DERBY-2495 > URL: https://issues.apache.org/jira/browse/DERBY-2495 > Project: Derby > Issue Type: Sub-task > Components: Network Client > Reporter: =C3=98ystein Gr=C3=B8vlen > Assigned To: =C3=98ystein Gr=C3=B8vlen > Fix For: 10.3.0.0 > > Attachments: blobframework.diff, blobframework_v2.diff, blobframe= work_v2.diff > > > The client JDBC driver will need to call stored procedures (ref DERBY-225= 7) to operate on LOBs identified by locators. We should create a framework= that implement the stored procedure calls. This way, the rest of the clie= nt code can call methods in this framework when needing to call the stored = procedures without having to prepare SQL statements themselves. =20 > The framework should make sure that prepared statements are reused within= a connection. Each procedure call should only be prepared once per connec= tion. > Since LOBs can not be parameters to stored procedures, the framework shou= ld make sure that calls involving a byte[] or String that does not fit in a= VARCHAR (FOR BIT DATA), are split into several calls each operating on a f= ragment of the LOB. --=20 This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.