db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rick Hillegas (JIRA)" <j...@apache.org>
Subject [jira] Commented: (DERBY-2506) Adding the locator information to FD:OCA descriptor (FDODSC) andFD:OCA data (FDODTA) of the SQLDTA objects
Date Mon, 30 Apr 2007 14:50:15 GMT

    [ https://issues.apache.org/jira/browse/DERBY-2506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12492681
] 

Rick Hillegas commented on DERBY-2506:
--------------------------------------

Thanks for the patch, Narayanan. I have a couple questions:

1) You have added some trace code to DRDAConnThread. Do you really want these tracesto be
printed out whenever we are running debug jars? Should these traces be enabled by some particular
tracepoint? Alternatively, is this just scaffolding which can be removed when you are done
debugging this code?

2) In NetStatementRequest.computeProtocolTypesAndLengths(), you are using the non-nullable
DRDA types for locators. All of the other cases in this switch statement are using the nullable
DRDA types. If you are sure that you should be using DRDA_TYPE_LOBLOC and DRDA_TYPE_CLOBLOC
rather than DRDA_TYPE_NLOBLOC and DRDA_TYPE_NCLOBLOC, could you include a comment explaining
why the locator cases are different from the other cases?

> Adding the locator information to FD:OCA descriptor (FDODSC) andFD:OCA data (FDODTA)
 of the SQLDTA objects
> -----------------------------------------------------------------------------------------------------------
>
>                 Key: DERBY-2506
>                 URL: https://issues.apache.org/jira/browse/DERBY-2506
>             Project: Derby
>          Issue Type: Sub-task
>            Reporter: V.Narayanan
>         Assigned To: V.Narayanan
>         Attachments: BlobLocatorTestProgram.java, PreparedCallable_DRDA_Test_diff.diff,
PreparedCallable_DRDA_Test_diff.stat, PreparedCallable_DRDA_Test_diff_v3.diff, PreparedCallable_DRDA_Test_diff_v3.stat,
PreparedCallable_DRDA_v1.diff, PreparedCallable_DRDA_v1.stat, PreparedCallable_DRDA_v2.diff,
PreparedCallable_DRDA_v2.stat, PreparedCallable_DRDA_v3.diff, PreparedCallable_DRDA_v3.stat,
PreparedCallable_DRDA_v4.diff, PreparedCallable_DRDA_v4.stat
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message