db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mamta A. Satoor (JIRA)" <j...@apache.org>
Subject [jira] Commented: (DERBY-2557) Provide a new interface on DataValueFactory(DVF) called getInstanceUsingFormatIdAndCollationType(formatId, collationType). This api will replace similar code in Monitor.
Date Wed, 18 Apr 2007 04:42:15 GMT

    [ https://issues.apache.org/jira/browse/DERBY-2557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12489605
] 

Mamta A. Satoor commented on DERBY-2557:
----------------------------------------

Army, thanks for the code review.

You are ofcourse right about "But that seems a tad odd to me... ". I meant to return the new
StringDataValue obtained through "getValue(...)". I will fix that very soon. Thanks for catching
it.

As for SQLChar.getValue(RuleBasedCollator), if the passed RuleBasedCollator is null then that
means that we have the right StringDataValue object ie we want to keep using this DVD which
has UCS_BASIC collation associated with it. But if SQLChar.getValue(RuleBasedCollator) gets
called with non-null RuleBasedCollator, then we want to return CollatorSQLChar because CollatorSQLChar
uses the passed RuleBasedCollator for collation rather than using UCS_BASIC. Please let me
know if the comments on StringDataValue#getValue(RuleBasedCollator) are any help in understanding
this or you think more comments should go somewhere.

> Provide a new interface on DataValueFactory(DVF) called getInstanceUsingFormatIdAndCollationType(formatId,
collationType). This api will replace similar code in Monitor.
> -------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: DERBY-2557
>                 URL: https://issues.apache.org/jira/browse/DERBY-2557
>             Project: Derby
>          Issue Type: New Feature
>          Components: SQL
>    Affects Versions: 10.3.0.0
>            Reporter: Mamta A. Satoor
>         Assigned To: Mamta A. Satoor
>         Attachments: DERBY2557_getObject_Using_CollationType_FormatID_interface_on_DVF_v1_diff.txt,
DERBY2557_getObject_Using_CollationType_FormatID_interface_on_DVF_v1_stat.txt
>
>
> Provide a new interface, called getInstanceUsingFormatIdAndCollationType(formatId, collationType)
on DVF. Store will call this interface to create empty DVD objects and then load these DVD
objects using readExternal. For performance efficiency, when Store needs more of the same
base DVD, then on subsequent needs, it will call DVD.getNewNull rather than calling DVF.getInstanceUsingFormatIdAndCollationType
again. This work is required for DERBY-2537.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message