db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rick Hillegas (JIRA)" <j...@apache.org>
Subject [jira] Commented: (DERBY-2587) Connection.createClob() and Connection.createBlob() need to return locator support enabled LOB objects in the NetworkClient
Date Mon, 30 Apr 2007 15:20:15 GMT

    [ https://issues.apache.org/jira/browse/DERBY-2587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12492685
] 

Rick Hillegas commented on DERBY-2587:
--------------------------------------

Thanks for this patch, too, Narayanan. I have a couple suggestions:

1) Throughout the patch, the magic number -1 is used to mean "locators not enabled". I think
that the code would be less brittle if the magic number were replaced with a friendly constant
like LOCATORS_NOT_ENABLED.

2) Nit:  In CallableLocatorProcedures: "isLocatorSupportEnabled == false" seems like an awkward
way to say "!isLocatorSupportEnabled"

3) I was surprised by the comparison of the SQLState to a hardcoded "42Y03" rather than to
some expression involving LANG_NO_SUCH_METHOD_ALIAS. Is there some reason that you can't use
the friendly constant?


> Connection.createClob() and Connection.createBlob() need to return locator support enabled
LOB objects in the NetworkClient
> ---------------------------------------------------------------------------------------------------------------------------
>
>                 Key: DERBY-2587
>                 URL: https://issues.apache.org/jira/browse/DERBY-2587
>             Project: Derby
>          Issue Type: Sub-task
>            Reporter: V.Narayanan
>         Assigned To: V.Narayanan
>         Attachments: ConnectionLocatorWork_v1.diff, ConnectionLocatorWork_v1.stat
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message