db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kristian Waagan (JIRA)" <j...@apache.org>
Subject [jira] Commented: (DERBY-2346) Provide set methods for clob for embedded driver
Date Wed, 18 Apr 2007 16:20:16 GMT

    [ https://issues.apache.org/jira/browse/DERBY-2346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12489809
] 

Kristian Waagan commented on DERBY-2346:
----------------------------------------

Thank you Anurag.

I want this issue to move on. Therefore I have chosen to commit the version 3 patch, even
though it needs more work.
The reason for the somewhat "premature" commit is that reviewing these big patches is time-consuming.
Further, at least for me, it is hard to stay focused...

Committed 'derby-2346v3.diff' to trunk with revision 530085.
Ran derbyall and suites.All with JDK 1.6 without failures.

One or more followup patches are required.
Regarding my own previous comments first:
1, (3), 4 - 9, 11 - 12, 14, 19 - 20, 22 have been addressed.
These have not been addressed (or commented/rejected):
 2) Can the field writer be made final?
10) There's another new String() that can be replaced with String.copyValueOf() in EmbedClob.
There is also some debug code in there (System.out.printlns).
13) Not addressed.
15) A few words for the class JavaDoc?
16) Not addressed.
18) I would like a comment on this one.

17, 21, 23 - 24 are more general. I'll maybe look at them later.

I also checked for changes regarding the comments Knut Anders made.
As far as I can see, you will handle the first one in a separate patch, the two next are addressed,
whereas the rest is not addressed or I have not looked into them.
One comment about the fourth comment: A change has been made, but I don't think the intended
one was made. The variable changed to int (length) should be a long, whereas ret should be
changed from long to int.

I also have a few nits on JavaDoc and some other minor stuff, but I'll comment on this or
make a patch for it later.


regards,

> Provide set methods for clob for embedded driver
> ------------------------------------------------
>
>                 Key: DERBY-2346
>                 URL: https://issues.apache.org/jira/browse/DERBY-2346
>             Project: Derby
>          Issue Type: Sub-task
>          Components: JDBC
>    Affects Versions: 10.3.0.0
>            Reporter: Anurag Shekhar
>         Assigned To: Anurag Shekhar
>         Attachments: derby-2346-only_for_review.diff, derby-2346.v1.diff, derby-2346v2.diff,
derby-2346v3.diff
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message