db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jørgen Løland (JIRA) <j...@apache.org>
Subject [jira] Commented: (DERBY-1825) Errors 2850A,2850G,28508 are similar - can be combined into a single message.
Date Wed, 18 Apr 2007 11:26:15 GMT

    [ https://issues.apache.org/jira/browse/DERBY-1825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12489696
] 

Jørgen Løland commented on DERBY-1825:
--------------------------------------

I have reexamined the error messages with respect to localization. First of all, 2850E, 2850H.C,
2850I.C and 2850J.C are not merged due to the problem described by Dag.

28506 and 2850G can be merged into one message 

    User '{0}' does not have {1} permission on {2} '{3}'.'{4}'.

If this is done, however, the former "table" and "object" words will be replaced with "Table/View"
since this is what is returned from TableDescriptor#getDescriptorType. Hence, the messages

ERROR 28506: User 'USER2' does not have insert permission on table 'USER1'.'DERBYDB'.
ERROR 2850G: User 'USER2' does not have grant permission on object 'USER1'.'TEST'.

will be replaced with

ERROR 28506: User 'USER2' does not have insert permission on Table/View 'USER1'.'DERBYDB'.
ERROR 28506: User 'USER2' does not have grant permission on Table/View 'USER1'.'TEST'.

Note that the privilege names ("select/insert/grant" etc) are not localized in the current
code (TablePrivilegeInfo#checkPrivileges and StatementTablePermission#check). If the word
"execute" of ERROR 2850A can be non-localized similarly, 2850A can also be merged with 28506
and 2850G.

1) Should 28506 and 2850G be merged with the described "Table/View" effect?
2) Should 2850A also be merged with these, resulting in non-localized "execute"?

The merging of errors 28507 and 2850B inherits both 1) and 2). Hence, if the answer is yes
to both questions, they
will be merged.

> Errors 2850A,2850G,28508 are similar - can be combined into a single message.
> -----------------------------------------------------------------------------
>
>                 Key: DERBY-1825
>                 URL: https://issues.apache.org/jira/browse/DERBY-1825
>             Project: Derby
>          Issue Type: Improvement
>          Components: SQL
>            Reporter: Daniel John Debrunner
>         Assigned To: Jørgen Løland
>
> ERROR 2850A: User 'SAM' does not have execute permission on PROCEDURE 'SYSCS_UTIL'.'SYSCS_EXPORT_TABLE'.
> ERROR 2850G: User 'MAMTA2' does not have grant permission on object 'MAMTA2'.'V21VIEWTEST'.
> ERROR 28508: User 'MAMTA3' does not have select permission on column 'C111' of table
'MAMTA2'.'V21VIEWTEST'. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message