db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kathey Marsden (JIRA)" <j...@apache.org>
Subject [jira] Commented: (DERBY-2539) convert lang/timestampArith.java to JUnit
Date Sat, 21 Apr 2007 00:18:15 GMT

    [ https://issues.apache.org/jira/browse/DERBY-2539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12490481
] 

Kathey Marsden commented on DERBY-2539:
---------------------------------------


I think I see what you mean about the fail statements.   There are 
instances where you catch an exception and then throw it, where just 
letting the exception be thrown would suffice.
For example:

+				try {
+					rs.close();
+				} catch (SQLException sqle) {
+					throw sqle;

                                                                    }

can be written as:
rs.close();

since runTests throws an SQLException

Do you have any objection to my changing these cases before I checkin 
the change?

Thanks

Kathey



> convert lang/timestampArith.java to JUnit
> -----------------------------------------
>
>                 Key: DERBY-2539
>                 URL: https://issues.apache.org/jira/browse/DERBY-2539
>             Project: Derby
>          Issue Type: Test
>          Components: Test
>            Reporter: Ugo Matrangolo
>         Assigned To: Ugo Matrangolo
>            Priority: Minor
>         Attachments: DERBY-2539_diff_200407.txt, DERBY-2539_diff_210407.txt, DERBY-2539_stat_200407.txt,
DERBY-2539_stat_210407.txt
>
>
> convert lang/timestampArith.java to JUnit

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message