Return-Path: Delivered-To: apmail-db-derby-dev-archive@www.apache.org Received: (qmail 59572 invoked from network); 15 Mar 2007 19:00:07 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 15 Mar 2007 19:00:07 -0000 Received: (qmail 38218 invoked by uid 500); 15 Mar 2007 19:00:15 -0000 Delivered-To: apmail-db-derby-dev-archive@db.apache.org Received: (qmail 38187 invoked by uid 500); 15 Mar 2007 19:00:15 -0000 Mailing-List: contact derby-dev-help@db.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: Delivered-To: mailing list derby-dev@db.apache.org Received: (qmail 38178 invoked by uid 99); 15 Mar 2007 19:00:15 -0000 Received: from herse.apache.org (HELO herse.apache.org) (140.211.11.133) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 15 Mar 2007 12:00:15 -0700 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received-SPF: neutral (herse.apache.org: local policy) Received: from [32.97.182.141] (HELO e1.ny.us.ibm.com) (32.97.182.141) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 15 Mar 2007 12:00:02 -0700 Received: from d01relay04.pok.ibm.com (d01relay04.pok.ibm.com [9.56.227.236]) by e1.ny.us.ibm.com (8.13.8/8.13.8) with ESMTP id l2FIxedM026605 for ; Thu, 15 Mar 2007 14:59:40 -0400 Received: from d01av03.pok.ibm.com (d01av03.pok.ibm.com [9.56.224.217]) by d01relay04.pok.ibm.com (8.13.8/8.13.8/NCO v8.3) with ESMTP id l2FIwOGt225220 for ; Thu, 15 Mar 2007 14:58:24 -0400 Received: from d01av03.pok.ibm.com (loopback [127.0.0.1]) by d01av03.pok.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id l2FIwN1c015987 for ; Thu, 15 Mar 2007 14:58:23 -0400 Received: from [127.0.0.1] (sig-9-76-199-235.mts.ibm.com [9.76.199.235]) by d01av03.pok.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id l2FIwM7s015925 for ; Thu, 15 Mar 2007 14:58:23 -0400 Message-ID: <45F9974D.7060709@apache.org> Date: Thu, 15 Mar 2007 11:58:21 -0700 From: Daniel John Debrunner User-Agent: Thunderbird 1.5.0.10 (Windows/20070221) MIME-Version: 1.0 To: derby-dev@db.apache.org Subject: Re: Collation implementation WAS Re: Should COLLATION attribute related code go in BasicDatabase? References: <45F6E90F.2090706@apache.org> <45F9620E.4050105@apache.org> <45F98467.6090602@sbcglobal.net> <45F98C46.6030407@apache.org> <45F99042.7000307@sbcglobal.net> <45F99287.2070807@sbcglobal.net> In-Reply-To: <45F99287.2070807@sbcglobal.net> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org Mike Matrigali wrote: > > > Mike Matrigali wrote: >> >> >> Daniel John Debrunner wrote: >> >>> Mike Matrigali wrote: >>> >>>> I think I am missing/not understanding your direction. >>>> >>>> are there still 4 new types? >>> >>> >>> >>> No, collation becomes an attribute of the existing character types >>> just like length and nullability are. > What is CollatorSQLChar in your proposal then? Same as in Mamta's current code. CollatorSQLChar is a DataValueDescriptor, these are holders for values of a type, they are not a type themselves. I think that's where the confusion is coming in. A type in Derby is composed of much more. The type definition of a column is described by a DataTypeDescriptor, it is this class that would hold extra information (an int) to describe the collation type. Also some changes for classes involved in type creation at compile time will be needed, CharTypeCompiler at least. A writeup of the roles of the type classes is in the package.html for the types package. http://db.apache.org/derby/javadoc/engine/org/apache/derby/iapi/types/package-summary.html#package_description So there would be four new classes that implement DataValueDescriptor, for the Collator based collation of the four existing character types, as Mamta has implicitly proposed. But there would not be four new internal types and all the overhead it entails. Dan.