Mailing-List: contact derby-dev-help@db.apache.org; run by ezmlm
Precedence: bulk
Reply-To: <derby-dev@db.apache.org>
Message-ID: <11446299.1173866469692.JavaMail.jira@brutus>
Date: Wed, 14 Mar 2007 03:01:09 -0700 (PDT)
From: "V.Narayanan (JIRA)" <jira@apache.org>
To: derby-dev@db.apache.org
Subject: [jira] Commented: (DERBY-2443) Implement ResultSet
 updateClob/updateBlob methods  on the NetworkClient
In-Reply-To: <7528037.1173516969275.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/DERBY-2443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12480708 ] 

V.Narayanan commented on DERBY-2443:
------------------------------------

Thank you for looking at the patch!!

>Can't you just remove the if-else block and do the assert, which seems to be common for all cases? 

The existing code does it that way and I did not disturb it. I just changed the SQLState. However I agree to this and shall make this change in my follow-up patch.

>There are also some long lines in client/am/ResultSet. 

I shall fix these formatting issues in a follow-up patch.


> Implement ResultSet updateClob/updateBlob methods  on the NetworkClient
> -----------------------------------------------------------------------
>
>                 Key: DERBY-2443
>                 URL: https://issues.apache.org/jira/browse/DERBY-2443
>             Project: Derby
>          Issue Type: Improvement
>          Components: Network Client
>         Environment: All
>            Reporter: V.Narayanan
>         Assigned To: V.Narayanan
>         Attachments: ResultSetNotImplMethods_v1.diff, ResultSetNotImplMethods_v1.stat
>
>
> Implement the following ResultSet methods on the Network Client
> updateBlob(int columnIndex, Blob x)
>  updateBlob(String columnName, Blob x)
>  updateClob(int columnIndex, Clob x)
>  updateClob(String columnName, Clob x)
>  updateBlob(int columnIndex, InputStream x, long length)
>  updateBlob(String columnName, InputStream x, long length)
>  updateClob(int columnIndex, Reader x, long length)
>  updateClob(String columnName, Reader x, long length)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.