db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dag H. Wanvik (JIRA)" <j...@apache.org>
Subject [jira] Commented: (DERBY-2418) TestProto.java used by testProtocol.java hardcodes port 1527
Date Fri, 23 Mar 2007 16:44:32 GMT

    [ https://issues.apache.org/jira/browse/DERBY-2418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12483649

Dag H. Wanvik commented on DERBY-2418:

The patch looks good to me now, I recommend it be committed. Thanks
for fixing this, Julius!

Some whitespace nits which you may want to fix yourself, or wait for
the committer's decision:

- in TestFile.java, line 57  exceeds 80 characters

- in TestProto.java, the prevailing convention is to use tab rather
  than blanks for indentation. While we generally prefer blanks in
  Derby for new files, we try to stick to the surrounding lines'
  convention, in part to make diff files look better (since tab often
  expands to eight under Unix, rather than Derby's convention of 4).

  Many new lines are indented using blanks, rather than tabs.
  Line 158 and 186 has been modified and now use use blanks for whitespace.
  Line 184  has been modified to use a (different) mix of blanks and tab
  whitespace: blanks before tabs in indentation.

- in testProtocol.java, modified line 54 exceeds 80 characters

I realize this is a bit of a bore; the whitespace situation is Derby
is a mess, unfortunately, but we strive to avoid making it
worse. Hopefully one day we can decide on a suitable time to get rid
of tab characters..

> TestProto.java used by testProtocol.java hardcodes port 1527
> ------------------------------------------------------------
>                 Key: DERBY-2418
>                 URL: https://issues.apache.org/jira/browse/DERBY-2418
>             Project: Derby
>          Issue Type: Improvement
>          Components: Test
>            Reporter: Dag H. Wanvik
>         Assigned To: Julius Stroffek
>            Priority: Minor
>         Attachments: d2418.diff, d2418.stat, d2418_try2.diff, d2418_try2.stat
> NetHarnessJavaTest reuses the old framework test 'testProtocol' via
> old framework adapter HarnessJavaTest.
> testProtocol uses the class TestProto which hardcodes use of port 1527.
> It would be nice to pass the port used in the current TestConfiguration
> to testProtocol/TestProto so the JUnit suites can move towards being runnable
> with another port than the default. 
> Currently, using another port than 1527 for TestConfiguration.DEFAULT_PORT,
>  the test fails and crashes JUnit's TestRunner with the console message:
> Couldn't get I/O for the connection to: localhost

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message