db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew McIntyre (JIRA)" <j...@apache.org>
Subject [jira] Commented: (DERBY-2392) Create verbose option to get the queries which are currently running
Date Thu, 15 Mar 2007 22:33:09 GMT

    [ https://issues.apache.org/jira/browse/DERBY-2392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12481348
] 

Andrew McIntyre commented on DERBY-2392:
----------------------------------------

Committed -ver2 patch with revision 518785.

Two nitpicky issues:

DataUtils.createObjects has a println that is not surrounded by an if (verbose) {}, but it's
in a catch block, so maybe you wanted it to always be printed?

In the main method, in the for loop where you parse the arguments, if an unknown argument
is passed, you return from the main method. It might be a good idea to System.exit(1) here.
Not sure how this might interact with a possible Junit wrapper for the test, though.

Anyway, no need to change the test if these are intended behavior. Feel free to resolve and
close this issue if it is complete.

> Create verbose option to get the queries which are currently running
> --------------------------------------------------------------------
>
>                 Key: DERBY-2392
>                 URL: https://issues.apache.org/jira/browse/DERBY-2392
>             Project: Derby
>          Issue Type: Sub-task
>            Reporter: Manjula Kutty
>         Assigned To: Manjula Kutty
>            Priority: Trivial
>         Attachments: DERBY-2392_diff_ver1.txt, DERBY-2392_diff_ver2.txt, DERBY-2392_stat_ver1.txt,
DERBY-2392_stat_ver2.txt
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message