db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Daniel John Debrunner (JIRA)" <j...@apache.org>
Subject [jira] Commented: (DERBY-2458) Convert lang/unaryArithmeticDynamicParamter.java to junit
Date Tue, 20 Mar 2007 00:02:32 GMT

    [ https://issues.apache.org/jira/browse/DERBY-2458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12482275
] 

Daniel John Debrunner commented on DERBY-2458:
----------------------------------------------

Patch generally looks good but it's good to have clear & logical naming. The new utility
method you've added JDBC.assertColumnTypes is not checking column types, it's checking parameter
types. That's the danger of copying other code, as I see it see has comments in its javadoc
related to DatabaseMetaData which is not relevant here.

And then I would be more explicit on the JDBC3 requirement, just stating the test requires
ParameterMetaData I think would be clearer than "it relies on jdk14 jdbc metadata calls"



> Convert lang/unaryArithmeticDynamicParamter.java to junit
> ---------------------------------------------------------
>
>                 Key: DERBY-2458
>                 URL: https://issues.apache.org/jira/browse/DERBY-2458
>             Project: Derby
>          Issue Type: Test
>          Components: Test
>    Affects Versions: 10.3.0.0
>            Reporter: Manjula Kutty
>         Assigned To: Manjula Kutty
>            Priority: Trivial
>             Fix For: 10.3.0.0
>
>         Attachments: DERBY-2458_diff_03_16.txt, DERBY-2458_diff_03_16_ver2.txt, DERBY-2458_diff_03_19.txt,
DERBY-2458_diff_ver1.txt, DERBY-2458_stat_03_19.txt, DERBY-2458_stat_ver1.txt
>
>
> Place holder to convert lang/unaryArithmeticDynamicParameter.java to junit

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message