db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Daniel John Debrunner (JIRA)" <j...@apache.org>
Subject [jira] Commented: (DERBY-2422) convert lang/holdCursorjava.java to junit
Date Fri, 09 Mar 2007 02:52:24 GMT

    [ https://issues.apache.org/jira/browse/DERBY-2422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12479485

Daniel John Debrunner commented on DERBY-2422:

I'm not sure what the method checkResultSet() is trying to check. It's comments don't really
match its code.
There are already a series of assert for ResultSets in the JDBC utility class, could one of
those work instead.
If not, then checkResultSet() needs to be cleaned up, e.g. at the moment if null is passed
in then the assert will pass.

Holdability is supported in JSR169 and JDBC 3, basically all environments Derby runs in.

Rather than use a test specific HaveDriverManager the test should be using JDBC.vmSupportsJDBC3()
since DriverManager is a feature of JDBC 3.

> convert lang/holdCursorjava.java to junit
> -----------------------------------------
>                 Key: DERBY-2422
>                 URL: https://issues.apache.org/jira/browse/DERBY-2422
>             Project: Derby
>          Issue Type: Bug
>          Components: Test
>    Affects Versions:
>            Reporter: Manjula Kutty
>         Assigned To: Manjula Kutty
>            Priority: Trivial
>             Fix For:
>         Attachments: DERBY-2422_diff_ver1.txt, DERBY-2422_stat_ver1.txt
> Place holder for the conversion of the test lang/holdCursorJava.java to junit

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message