db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dag H. Wanvik (JIRA)" <j...@apache.org>
Subject [jira] Commented: (DERBY-2418) TestProto.java used by testProtocol.java hardcodes port 1527
Date Fri, 16 Mar 2007 17:50:09 GMT

    [ https://issues.apache.org/jira/browse/DERBY-2418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12481713
] 

Dag H. Wanvik commented on DERBY-2418:
--------------------------------------

I agree that passing this in via the constructor is better. As an
option 3), instead of removing TestFile.java, you could also just have
that class pass in the port, by letting TestFile import
NetworkServerControl.DEFAULT_PORTNUMBER. That way, the
semantics of TestFile.java would be unchanged.

I would not recommend option 1) since that defeats the purpose of
 having the tests rely on the test configuration for the port number.



> TestProto.java used by testProtocol.java hardcodes port 1527
> ------------------------------------------------------------
>
>                 Key: DERBY-2418
>                 URL: https://issues.apache.org/jira/browse/DERBY-2418
>             Project: Derby
>          Issue Type: Improvement
>          Components: Test
>            Reporter: Dag H. Wanvik
>         Assigned To: Julius Stroffek
>            Priority: Minor
>         Attachments: d2418.diff, d2418.stat
>
>
> NetHarnessJavaTest reuses the old framework test 'testProtocol' via
> old framework adapter HarnessJavaTest.
> testProtocol uses the class TestProto which hardcodes use of port 1527.
> It would be nice to pass the port used in the current TestConfiguration
> to testProtocol/TestProto so the JUnit suites can move towards being runnable
> with another port than the default. 
> Currently, using another port than 1527 for TestConfiguration.DEFAULT_PORT,
>  the test fails and crashes JUnit's TestRunner with the console message:
> Couldn't get I/O for the connection to: localhost

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message