db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dag H. Wanvik (JIRA)" <j...@apache.org>
Subject [jira] Commented: (DERBY-2418) TestProto.java used by testProtocol.java hardcodes port 1527
Date Fri, 09 Mar 2007 23:59:09 GMT

    [ https://issues.apache.org/jira/browse/DERBY-2418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12479773

Dag H. Wanvik commented on DERBY-2418:

Thanks for the quick patch, Julius!  I think it is good.

You may want to avoid 1527 as a magical constant in initialize(). You
(or committer) should probably use TestConfiguration.DEFAULT_PORT
instead (to be replaced soon by whatever constant DERBY-2419 ends up
with for Derby's default port - not to be confused with the preferred
port for the present run, cf. items 1) and 2) in

Now, when we make DerbyNetNewServer rely on getPort as well,
we should have a clean bill of health for suites.All wrt port usage, cf
my comment to this issue on derby-dev on Thursday.


> TestProto.java used by testProtocol.java hardcodes port 1527
> ------------------------------------------------------------
>                 Key: DERBY-2418
>                 URL: https://issues.apache.org/jira/browse/DERBY-2418
>             Project: Derby
>          Issue Type: Improvement
>          Components: Test
>            Reporter: Dag H. Wanvik
>         Assigned To: Julius Stroffek
>            Priority: Minor
>         Attachments: d2418.diff, d2418.stat
> NetHarnessJavaTest reuses the old framework test 'testProtocol' via
> old framework adapter HarnessJavaTest.
> testProtocol uses the class TestProto which hardcodes use of port 1527.
> It would be nice to pass the port used in the current TestConfiguration
> to testProtocol/TestProto so the JUnit suites can move towards being runnable
> with another port than the default. 
> Currently, using another port than 1527 for TestConfiguration.DEFAULT_PORT,
>  the test fails and crashes JUnit's TestRunner with the console message:
> Couldn't get I/O for the connection to: localhost

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message