db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "A B (JIRA)" <j...@apache.org>
Subject [jira] Commented: (DERBY-2376) Patch available to make .classpath entries portable - relative to ECLIPSE_HOME
Date Tue, 06 Mar 2007 18:33:24 GMT

    [ https://issues.apache.org/jira/browse/DERBY-2376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12478505
] 

A B commented on DERBY-2376:
----------------------------

I have zero experience in this particular are of the Derby code and I've never used the UI
plugin, so I don't have much to offer in the way of review.  Just the following relatively
unimportant stylistic notes:

1) It'd be great if you could add comments to the code that explain the justification behind
the change.  You've mentioned why this is needed in the Jira and also in your email to derby-dev,
but the code itself has no explanation.

 2) Would it make sense to use a constant variable for "ECLIPSE_HOME/plugins" instead of using
the literal twice? Not by any means a requirement, just a suggestion.

And one question: looking at this patch I assume that, currently, whenever derby lib entires
are added the absolute path *always* starts with the expanded form of "ECLISPE_HOME/plugins".
 Is that correct?  Is it ever possible for the path to start with something else?  (maybe
showing my ignorance of Eclipse plugins right now...sorry).  Or put another way, is there
any chance that existing users of the Derby UI  plugin might see altered behavior as a result
of this change?  If so, what are the scenarios in which that might happen?

> Patch available to make .classpath entries portable - relative to ECLIPSE_HOME
> ------------------------------------------------------------------------------
>
>                 Key: DERBY-2376
>                 URL: https://issues.apache.org/jira/browse/DERBY-2376
>             Project: Derby
>          Issue Type: Sub-task
>          Components: Eclipse Plug-in
>    Affects Versions: 10.2.2.0
>         Environment: any with eclipse
>            Reporter: Aaron Tarter
>             Fix For: 10.2.2.1
>
>         Attachments: DerbyUtils.diff
>
>
> This patch modifies the DerbyUtils class to add variable entries relative to ECLIPSE_HOME
as described in the comments below, so that eclipse projects with Derby Nature can be committed
to an SCM without causing build path errors. I did not think any of the derby functional tests
were applicable to this ui action, so I manually tested the code by trying the following:
> 1) Adding Derby Nature to a java project
> 2) Starting and stopping a database with the derby nature
> 3) Removing the Derby Nature from a java project
> The code modification is only required on the add and not on the remove since the current
remove looks for any entry that ends with the correct JAR names.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message