db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "John H. Embretsen (JIRA)" <j...@apache.org>
Subject [jira] Updated: (DERBY-2501) Batch scripts in bin\ report extraneous errors when DERBY_HOME is invalid
Date Thu, 29 Mar 2007 09:56:25 GMT

     [ https://issues.apache.org/jira/browse/DERBY-2501?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

John H. Embretsen updated DERBY-2501:
-------------------------------------

    Attachment: d2501_v1.diff

Attaching a patch 'd2501_v1.diff', which modifies the following file in trunk:

M      bin\derby_common.bat

The patch renames the "noAntHome" label to "noDerbyHome" and goes to the label "endcommon"
instead of the non-existing "end" after the noDerbyHome error message is displayed. This eliminates
error message 2).

This patch does not do anything with error message 3), as I am not sure what the best way
to handle this is. It could be removed by adding a check for _JAVACMD in all the scripts that
call derby_common.bat, or perhaps by letting the derby_common.bat script call the "end" label
of the parent scripts directly, but I fear that the latter option might be unnecessarily complicated
to implement. Any comments or suggestions are appreciated!

Please review / commit this simple patch.


> Batch scripts in bin\ report extraneous errors when DERBY_HOME is invalid
> -------------------------------------------------------------------------
>
>                 Key: DERBY-2501
>                 URL: https://issues.apache.org/jira/browse/DERBY-2501
>             Project: Derby
>          Issue Type: Bug
>          Components: Demos/Scripts
>    Affects Versions: 10.2.1.6, 10.2.2.0
>         Environment: Windows
>            Reporter: John H. Embretsen
>         Assigned To: John H. Embretsen
>            Priority: Trivial
>             Fix For: 10.3.0.0
>
>         Attachments: d2501_v1.diff
>
>
> If DERBY_HOME is set to an invalid location (for example a directory that does not contain
lib\derby.jar), most .bat scripts in the bin directory (the ones that call derby_common.bat)
report three distinct error messages, of which only one is of value to the user. 
> Reproduction:
> C:\Derby_10\db-derby-10.2.2.0-bin>set DERBY_HOME=c:\temp
> C:\Derby_10\db-derby-10.2.2.0-bin>echo %DERBY_HOME%
> c:\temp
> C:\Derby_10\db-derby-10.2.2.0-bin>bin\sysinfo
> DERBY_HOME is set incorrectly or derby.jar could not be located. Please set DERBY_HOME.
> The system cannot find the batch label specified - end
> '""' is not recognized as an internal or external command,
> operable program or batch file.
> The distinct error messages are:
> 1) DERBY_HOME is set incorrectly or derby.jar could not be located. Please set DERBY_HOME.
> 2) The system cannot find the batch label specified - end
> 3) '""' is not recognized as an internal or external command, operable program or batch
file.
> Only 1) is relevant for the user, and should ideally be the only one displayed.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message