db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Julius Stroffek (JIRA)" <j...@apache.org>
Subject [jira] Updated: (DERBY-2418) TestProto.java used by testProtocol.java hardcodes port 1527
Date Fri, 09 Mar 2007 15:35:24 GMT

     [ https://issues.apache.org/jira/browse/DERBY-2418?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Julius Stroffek updated DERBY-2418:
-----------------------------------

    Attachment: d2418.stat
                d2418.diff

A patch is really simple - I have done following:

1.) moved a code from TestProto constructor to initialize method
2.) added a constructor of TestProto with port number
3.) added a port number to a call to TestProto constructor in testProtocol.java. The port
number is recevied by a call to TestConfiguration.getCurrent().getPort()

I ran derbyall and suites.All without failures. I hardcoded port 1529 as TestConfiguration.DEFAULT_PORT
and run suites.All again without any failures.

Actually, HarnessJavaTest has one failure for both runs, but this happens to me for last 2
weeks every time. I think there is a problem with string comparison and it is probably a locale/encoding
issue and has nothing to do with my change.

> TestProto.java used by testProtocol.java hardcodes port 1527
> ------------------------------------------------------------
>
>                 Key: DERBY-2418
>                 URL: https://issues.apache.org/jira/browse/DERBY-2418
>             Project: Derby
>          Issue Type: Improvement
>          Components: Test
>            Reporter: Dag H. Wanvik
>         Assigned To: Julius Stroffek
>            Priority: Minor
>         Attachments: d2418.diff, d2418.stat
>
>
> NetHarnessJavaTest reuses the old framework test 'testProtocol' via
> old framework adapter HarnessJavaTest.
> testProtocol uses the class TestProto which hardcodes use of port 1527.
> It would be nice to pass the port used in the current TestConfiguration
> to testProtocol/TestProto so the JUnit suites can move towards being runnable
> with another port than the default. 
> Currently, using another port than 1527 for TestConfiguration.DEFAULT_PORT,
>  the test fails and crashes JUnit's TestRunner with the console message:
> Couldn't get I/O for the connection to: localhost

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message