Return-Path: Delivered-To: apmail-db-derby-dev-archive@www.apache.org Received: (qmail 41055 invoked from network); 27 Feb 2007 17:26:29 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 27 Feb 2007 17:26:28 -0000 Received: (qmail 7494 invoked by uid 500); 27 Feb 2007 17:26:35 -0000 Delivered-To: apmail-db-derby-dev-archive@db.apache.org Received: (qmail 7438 invoked by uid 500); 27 Feb 2007 17:26:35 -0000 Mailing-List: contact derby-dev-help@db.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: Delivered-To: mailing list derby-dev@db.apache.org Received: (qmail 7365 invoked by uid 99); 27 Feb 2007 17:26:35 -0000 Received: from herse.apache.org (HELO herse.apache.org) (140.211.11.133) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 27 Feb 2007 09:26:35 -0800 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO brutus.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 27 Feb 2007 09:26:26 -0800 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id E0025714049 for ; Tue, 27 Feb 2007 09:26:05 -0800 (PST) Message-ID: <17177322.1172597165915.JavaMail.jira@brutus> Date: Tue, 27 Feb 2007 09:26:05 -0800 (PST) From: "Rick Hillegas (JIRA)" To: derby-dev@db.apache.org Subject: [jira] Commented: (DERBY-2378) SecureServerTest should not be using non-public apis In-Reply-To: <9797739.1172595965491.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/DERBY-2378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12476236 ] Rick Hillegas commented on DERBY-2378: -------------------------------------- This is an interesting topic which I would like to understand better. It seems that there is a great deal of Derby's public API which is not visible in the relatively small number of classes which we expose in the javadoc shipped with our distributions. For instance, error messages and command line arguments are part of Derby's public API which we document in our user guides but not in the javadoc. I think it is reasonable to test that Derby conforms to the behavior documented in the user guides. Is the issue here the actual imports? Is there a best practice for eliminating these imports but still verifying that the code agrees with the user guides? > SecureServerTest should not be using non-public apis > ----------------------------------------------------- > > Key: DERBY-2378 > URL: https://issues.apache.org/jira/browse/DERBY-2378 > Project: Derby > Issue Type: Bug > Components: Test > Affects Versions: 10.3.0.0 > Reporter: Daniel John Debrunner > > Functional tests should not be written against Derby's public api, not its internals. > One reason is that it will make it harder to run the tests against different versions of Derby to test for regressions (e.g. run 10.3 tests against 10.4) > The code imports these classes that are not part of the public api. > import org.apache.derby.iapi.reference.Property; > import org.apache.derby.iapi.tools.i18n.LocalizedResource; > import org.apache.derby.impl.drda.NetworkServerControlImpl; -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.