db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Daniel John Debrunner (JIRA)" <j...@apache.org>
Subject [jira] Commented: (DERBY-2283) convert lang/currentof.java test to junit test
Date Fri, 02 Feb 2007 22:12:05 GMT

    [ https://issues.apache.org/jira/browse/DERBY-2283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12469893

Daniel John Debrunner commented on DERBY-2283:

Patch Committed revision 502769 - Thanks Manjula.

The test is lacking javadoc comments on the class and fixture methods, if you gained any knowledge
during the conversion it would be great if you could find time to save that knowledge as comments.
Even an overview in the class javadoc of what the test is covering would be good.

I think the remaining try/catch blocks could all use the JDBC.assertStatementError() utility
method, thus cleaning up the test even more.

In earlier comments I think you had said that this is the type of language test that should
run in client server as well, but it's only setup to run embedded. This would make it work
in both:

    public static Test suite() {
        return TestConfiguration.defaultSuite(CurrentOfTest.class);

> convert lang/currentof.java test to junit test
> ----------------------------------------------
>                 Key: DERBY-2283
>                 URL: https://issues.apache.org/jira/browse/DERBY-2283
>             Project: Derby
>          Issue Type: Test
>            Reporter: Manjula Kutty
>         Assigned To: Manjula Kutty
>            Priority: Minor
>             Fix For:
>         Attachments: _Suite.java, CurrentOfTest.java, svn_diff_02_02.txt, svn_stat_02_02.txt
> Using this Jira entry to attach the converted test in future

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message