db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anurag Shekhar (JIRA)" <j...@apache.org>
Subject [jira] Updated: (DERBY-2247) provide set methods for blob in embeded driver
Date Sun, 11 Feb 2007 21:33:05 GMT

     [ https://issues.apache.org/jira/browse/DERBY-2247?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Anurag Shekhar updated DERBY-2247:
----------------------------------

    Attachment: derby-2247-v3-usingStoreFactory.diff

Thanks Narayanan for looking at the patch.

>Pls mention reason for choosing buffer size as 4096, if there was a particular
reason for choosing this value. Otherwise pls mention that it was a random
value. 

it's a randomly selected value. added a comment to indicate that.

>Can the Monitor and the DataFactory be resused instead of doing a findService,
findServiceModule each time? 

It can be cached but init is a one time operation. If we want to cache it for a database we
will have to add the varriable in connection. I don't think these calls are expensive enough
to justify that.

>String str = df.getStorageFactory().getTempDir().getPath(); (str is not being
used anywhere) 

It was a leftover of my debugging code taken it off.

>write methods 
>in all the three set methods. Is it possible that you can combine the code into one method
that can
be called from all the three set methods? 

these overloaded methods are calling out the overloaded methods in StorageRandomAccessFile
so actually they are three diff. methods.

>can materialized can be initialized to false during declaration?
>can control be initialized to null during declaration? 

false is the default value for uninitialized blob and null is default for uninitialized objects
so it doesn't makes any diff.

>you check the following in the set methods 
>But would'nt isValidPostion(pos) in control.write take care of this and throw
appropriate exception? 

I moved the check in not materialzed block as that won't go to LobStreamControl.

>There are a few missing javadocs and some javadocs missing the @throws tags. 

added @throws 

> provide set methods for blob in embeded driver
> ----------------------------------------------
>
>                 Key: DERBY-2247
>                 URL: https://issues.apache.org/jira/browse/DERBY-2247
>             Project: Derby
>          Issue Type: Sub-task
>          Components: JDBC
>         Environment: all
>            Reporter: Anurag Shekhar
>         Assigned To: Anurag Shekhar
>            Priority: Minor
>         Attachments: derby-2247-v3-usingStoreFactory.diff, derby-2247.diff, derby-2247v2-using_StoreFactory.diff
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message