db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Myrna van Lunteren (JIRA)" <j...@apache.org>
Subject [jira] Updated: (DERBY-2293) convert batchUpdate.java to junit
Date Wed, 07 Feb 2007 07:34:05 GMT

     [ https://issues.apache.org/jira/browse/DERBY-2293?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Myrna van Lunteren updated DERBY-2293:
--------------------------------------

    Attachment: DERBY-2293_20070206.diff
                DERBY-2293_20070206.stat

I'm attaching an updated patch.
I've tried to address the most of the comments (Thx for the review!):
- limited the length of text (and code too, for good measure)
- filtered out repeating code to an assertBatchExecuteError method
- renamed verifyBatchUpdateCounts to assertBatchUpdateCounts
- reworded comment containing resulti
- added license
- set lock time out
- revamped sections to use "  new int[] {1,1,1} " constructs to make expected values easier
to recognize
- corrected use of same connection in transaction tests
- made test work with network server as well as embedded
  This last one was not trivial because network server continues after an error,
  whereas embedded stops processing. So I've added if (usingEmbedded()
  and usingDerbyNetClient() sections, but seeing how little batch testing was
  occurring with networkserver/client, I thought it was worth it.

Also updated my tree so I could remove the original test from Dan's JavaHarnessAdapter.

I think that's it.

Test passes by itself using junit.textui.TestRunner.  I will run suites.All.

Reviews are welcome.


> convert batchUpdate.java to junit
> ---------------------------------
>
>                 Key: DERBY-2293
>                 URL: https://issues.apache.org/jira/browse/DERBY-2293
>             Project: Derby
>          Issue Type: Improvement
>          Components: Test
>            Reporter: Myrna van Lunteren
>         Assigned To: Myrna van Lunteren
>            Priority: Minor
>         Attachments: DERBY-2293_20070205.diff, DERBY-2293_20070205.stat, DERBY-2293_20070206.diff,
DERBY-2293_20070206.stat
>
>
> Convert the test jdbcapi.batchUpdate.java to junit framework

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message