db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Olav Sandstaa <Olav.Sands...@Sun.COM>
Subject Re: [jira] Updated: (DERBY-2328) Reduce monitor contention in SinglePool
Date Wed, 28 Feb 2007 12:16:08 GMT

I have downloaded and reviewed the patch. I like the introduction of the 
CompatibilitySpace interface and having to explicitly to create 
compatibility spaces. It mades the code more readable. Also removing the 
hash table from SinglePool is good both for simplifying the code, 
readability and performance (CPU and monitor contention). The patch 
looks very good.

I have only some very minor nits:

 * java/engine/org/apache/derby/impl/services/locks/LockSpace.java:

    -since you have changed the signature of the LockSpace constructor 
you should consider adding JavaDoc describing the new parameter (Object 
owner).
    -it might also be an idea to explain the "owner" concept in the 
JavaDoc for the class since this is a new concept you are introducing?
     (and if you change the JavaDoc for the class, you can probably also 
change the sentence refeering the "a hashtable keyed by..." to a "hash 
map keyed by....")

I have run the derbyall and Junit test suites with the patch. Only the 
two tests that currently fail in the thinderbox test failed.

+1 to commit this patch.

Thanks for the work on this, Knut Anders!

Regards,
Olav


Mime
View raw message