db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dyre Tjeldvoll (JIRA)" <j...@apache.org>
Subject [jira] Commented: (DERBY-2108) Implement SSL/TLS communication between client and server
Date Fri, 09 Feb 2007 15:37:06 GMT

    [ https://issues.apache.org/jira/browse/DERBY-2108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12471726

Dyre Tjeldvoll commented on DERBY-2108:

I think the patch is good, and represents a valuable addition to
derby. I have a few comments, but they're all nits and should not
delay a commit (but they prove that I have actually read through
the patch :):

General: Some lines are longer than 80 chars

Index: java/drda/org/apache/derby/impl/drda/ClientThread.java
@@ -31,64 +31,96 @@
+            try { // Check for al other exceptions.... 
<Missing l in 'all'>

+                    // This is a shutdown (I hope, what about a check?),
<I've noticed that some reviewers dislike comments like this
because it supposedly creates uncertainty. Personally I think it is fine
because it points to something (how exceptions are used) that is
not in the scope of this patch, but that perhaps should be looked

Index: java/drda/org/apache/derby/impl/drda/NetworkServerControlImpl.java
<space indentation, file has mostly tab indentation
private int getSSLModeValue(String) has an empty javadoc
comment. It is private so I don't think it really needs one, but
since the comment block was added in the patch it looks like you
meant to put something there.>

Index: java/client/org/apache/derby/jdbc/ClientDriver.java
@@ -172,7 +173,8 @@
+				key.equals(Attribute.PASSWORD_ATTR) ||
+                key.equals(Attribute.SSL_ATTR)) 
<Modified line is tab indented, added line is space indented. But
the file as a whole is mostly space indented, so what should one

Should SSL be mentioned in BUILDING.txt or release notes or some
other file (apart from the documentation)?

> Implement SSL/TLS communication between client and server
> ---------------------------------------------------------
>                 Key: DERBY-2108
>                 URL: https://issues.apache.org/jira/browse/DERBY-2108
>             Project: Derby
>          Issue Type: New Feature
>          Components: Network Client, Network Server
>            Reporter: Bernt M. Johnsen
>         Assigned To: Bernt M. Johnsen
>             Fix For:
>         Attachments: DERBY-2108-first-cut.diff, DERBY-2108-first-cut.stat, DERBY-2108-second-cut.diff,
DERBY-2108-second-cut.stat, DERBY-2108-third-cut.diff, DERBY-2108-third-cut.stat, derby-2108-v1.diff,
derby-2108-v1.stat, derby-2108-v2.diff, derby-2108-v2.diff, derby-2108-v2.stat, derby-2108-v3.diff,
derby-2108-v3.stat, SSLFuncSpect.txt
> Implement SSL/TLS communication between client and server

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message