db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jean T. Anderson (JIRA)" <j...@apache.org>
Subject [jira] Updated: (DERBY-2304) Convert derbynet/callable.java to junit
Date Wed, 28 Feb 2007 05:07:05 GMT

     [ https://issues.apache.org/jira/browse/DERBY-2304?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel

Jean T. Anderson updated DERBY-2304:

    Attachment: derby-2304.diff

(Never go on vacation -- it sets you behind by the amount you spent off * 2.)

I'm attaching derby-2304.diff, which incorporates the feedback I've received:

1) Tests that get/set BigDecimal only run if (!JDBC.vmSupportsJSR169())
2) Tests that need DriverManager only run if (JDBC.vmSupportsJDBC2()) 
3) The assertDecimalSameValue method wraps the BigDecimal.compareTo() call (I'll pass for
now on trying to get an equality check working).

I think one of the tests from derbynet/callable.java is dubious and I would appreciate opinions
-- I included it in the patch as testSystemOutPrintlnProc() . The sql procedure it invokes
just does this:

 System.out.println("I'm doing something here...");

So, of course, the window in which you run the junit test gets:
I'm doing something here...
I'm doing something here...

I somehow suspect System.out.println in a junit test isn't good, but I thought I'd ask. If
there's no feedback, I'm inclined to commit these changes with that test disabled.
And, of course, I'd appreciate any other observations anyone has.

> Convert derbynet/callable.java to junit
> ---------------------------------------
>                 Key: DERBY-2304
>                 URL: https://issues.apache.org/jira/browse/DERBY-2304
>             Project: Derby
>          Issue Type: Improvement
>          Components: Test
>            Reporter: Jean T. Anderson
>         Assigned To: Jean T. Anderson
>            Priority: Minor
>         Attachments: derby-2304-preview-2.diff, derby-2304-preview-3.diff, derby-2304-preview.diff,
> Convert the derbynet.callable.java test to the junit framework.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message