db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew McIntyre (JIRA)" <j...@apache.org>
Subject [jira] Updated: (DERBY-2342) convert importExport.java to junit
Date Sat, 17 Feb 2007 04:31:05 GMT

     [ https://issues.apache.org/jira/browse/DERBY-2342?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Andrew McIntyre updated DERBY-2342:
-----------------------------------

    Attachment: derby-2342-v3.diff

Thanks very much for the review, Suresh! Attaching a patch which incorporates most of your
suggestions.

I've used SupportFilesSetup.getReadWrite() to get the Files to pass to assertEquals(File,File).
For the other cases where the directory is hardcoded, we need to pass a String to the import
or export procedure. I could get a File or URL with getReadWrite or getReadWriteURL, but then
I'd either have to get the String representation of the File or URL and do some manipulation
of that String to get it into the format that the import/export procedures are expecting.
I'm not sure that it is worth the trouble to do that when the location of the support file
directories is unlikely to change.

Patch is still not quite ready to commit, though, as I'm seeing some failures on jdk16 in
client mode.

> convert importExport.java to junit
> ----------------------------------
>
>                 Key: DERBY-2342
>                 URL: https://issues.apache.org/jira/browse/DERBY-2342
>             Project: Derby
>          Issue Type: Improvement
>          Components: Tools
>    Affects Versions: 10.3.0.0
>            Reporter: Andrew McIntyre
>         Assigned To: Andrew McIntyre
>             Fix For: 10.3.0.0
>
>         Attachments: derby-2342-v1.diff, derby-2342-v1.stat, derby-2342-v2.diff, derby-2342-v3.diff
>
>
> Convert org.apache.derbyTesting.functionTests.tests.tools.importExport to junit. New
test is called ImportExportTest.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message