db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Myrna van Lunteren (JIRA)" <j...@apache.org>
Subject [jira] Updated: (DERBY-2293) convert batchUpdate.java to junit
Date Fri, 09 Feb 2007 03:00:17 GMT

     [ https://issues.apache.org/jira/browse/DERBY-2293?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Myrna van Lunteren updated DERBY-2293:
--------------------------------------

    Attachment: DERBY-2293_20070208.diff

New patch that does the following:

- does away with all passed on conns and stmts, renames all run* methods to test*, and identify
them at the top of the test as fixtures.
- reworked the suite(), and setUp() methods so that the tables are created once, and all records
get deleted from t1 in the setUp.
- removed the tearDown() (as a consequence not needed anymore)
- removed the superfluous assertBatchExecuteError for preparedStatements.
  only difference was in the message, so adjusted that to be more generic.
- tightened the try/catch blocks
- catching BatchUpdateExceptions rather than SQLExceptions where applicable
- suddenly t1 could get dropped in the two transaction methods/fixtures, so re-enabled them
for network server.

And removed the extra call in jdbcapi/_Suite.java. (Once is enough, I had put it in for testing
purposes and had forgotten to remove it).

Review is welcome.


> convert batchUpdate.java to junit
> ---------------------------------
>
>                 Key: DERBY-2293
>                 URL: https://issues.apache.org/jira/browse/DERBY-2293
>             Project: Derby
>          Issue Type: Improvement
>          Components: Test
>            Reporter: Myrna van Lunteren
>         Assigned To: Myrna van Lunteren
>            Priority: Minor
>         Attachments: DERBY-2293_20070205.diff, DERBY-2293_20070205.stat, DERBY-2293_20070206.diff,
DERBY-2293_20070206.stat, DERBY-2293_20070206_2.diff, DERBY-2293_20070208.diff
>
>
> Convert the test jdbcapi.batchUpdate.java to junit framework

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message