db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Daniel John Debrunner (JIRA)" <j...@apache.org>
Subject [jira] Commented: (DERBY-2378) SecureServerTest should not be using non-public apis
Date Tue, 27 Feb 2007 18:32:06 GMT

    [ https://issues.apache.org/jira/browse/DERBY-2378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12476299

Daniel John Debrunner commented on DERBY-2378:

> Is there a best practice for eliminating these imports but still verifying that the code
agrees with the user guides?

Write the test based upon the user guide?

With the test as-is, I think if someone incorrectly changed the flag from -noSecurityManager
to -noSecurityMger the test would not fail.

> SecureServerTest  should not be using non-public apis
> -----------------------------------------------------
>                 Key: DERBY-2378
>                 URL: https://issues.apache.org/jira/browse/DERBY-2378
>             Project: Derby
>          Issue Type: Bug
>          Components: Test
>    Affects Versions:
>            Reporter: Daniel John Debrunner
> Functional tests should not be written against Derby's public api, not its internals.
> One reason is that it will make it harder to run the tests against different versions
of Derby to test for regressions (e.g. run 10.3 tests against 10.4)
> The code imports these classes that are not part of the public api.
> import org.apache.derby.iapi.reference.Property;
> import org.apache.derby.iapi.tools.i18n.LocalizedResource;
> import org.apache.derby.impl.drda.NetworkServerControlImpl;

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message