Return-Path: Delivered-To: apmail-db-derby-dev-archive@www.apache.org Received: (qmail 75512 invoked from network); 15 Jan 2007 13:54:52 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 15 Jan 2007 13:54:52 -0000 Received: (qmail 99919 invoked by uid 500); 15 Jan 2007 13:54:57 -0000 Delivered-To: apmail-db-derby-dev-archive@db.apache.org Received: (qmail 99876 invoked by uid 500); 15 Jan 2007 13:54:57 -0000 Mailing-List: contact derby-dev-help@db.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: Delivered-To: mailing list derby-dev@db.apache.org Received: (qmail 99863 invoked by uid 99); 15 Jan 2007 13:54:57 -0000 Received: from herse.apache.org (HELO herse.apache.org) (140.211.11.133) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 15 Jan 2007 05:54:57 -0800 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO brutus.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 15 Jan 2007 05:54:48 -0800 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 318F67142BA for ; Mon, 15 Jan 2007 05:54:28 -0800 (PST) Message-ID: <3497655.1168869268200.JavaMail.jira@brutus> Date: Mon, 15 Jan 2007 05:54:28 -0800 (PST) From: "Knut Anders Hatlen (JIRA)" To: derby-dev@db.apache.org Subject: [jira] Commented: (DERBY-2191) Cleanup of FormatableBitSet In-Reply-To: <4003790.1166447903211.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/DERBY-2191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12464807 ] Knut Anders Hatlen commented on DERBY-2191: ------------------------------------------- I have committed fbstst.v1.diff to trunk with revision 496312. I made one minor change before committing: Some of the test cases used assertEquals(double, double, double) to compare two integers. Changed them to assertEquals(int, int) instead. > Cleanup of FormatableBitSet > --------------------------- > > Key: DERBY-2191 > URL: https://issues.apache.org/jira/browse/DERBY-2191 > Project: Derby > Issue Type: Improvement > Components: Miscellaneous > Affects Versions: 10.2.1.6 > Reporter: Dyre Tjeldvoll > Assigned To: Dyre Tjeldvoll > Priority: Trivial > Fix For: 10.3.0.0 > > Attachments: deadcode.v1.diff, deadcode.v2.diff, fbstst.v1.diff, fbstst.v1.stat, FormatableBitSetTest.java > > > The implementation of FormatableBitSet could be streamlined. Dead code can be removed and the implementation of some methods can be simplified. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira