Return-Path: Delivered-To: apmail-db-derby-dev-archive@www.apache.org Received: (qmail 42093 invoked from network); 11 Jan 2007 00:33:49 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 11 Jan 2007 00:33:49 -0000 Received: (qmail 79662 invoked by uid 500); 11 Jan 2007 00:33:55 -0000 Delivered-To: apmail-db-derby-dev-archive@db.apache.org Received: (qmail 79630 invoked by uid 500); 11 Jan 2007 00:33:55 -0000 Mailing-List: contact derby-dev-help@db.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: Delivered-To: mailing list derby-dev@db.apache.org Received: (qmail 79608 invoked by uid 99); 11 Jan 2007 00:33:55 -0000 Received: from herse.apache.org (HELO herse.apache.org) (140.211.11.133) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 10 Jan 2007 16:33:55 -0800 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO brutus.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 10 Jan 2007 16:33:47 -0800 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id A13A67142E4 for ; Wed, 10 Jan 2007 16:33:27 -0800 (PST) Message-ID: <25813562.1168475607657.JavaMail.jira@brutus> Date: Wed, 10 Jan 2007 16:33:27 -0800 (PST) From: "Daniel John Debrunner (JIRA)" To: derby-dev@db.apache.org Subject: [jira] Created: (DERBY-2229) UnsupportedVetter does not close the JDBC objects it opens MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org UnsupportedVetter does not close the JDBC objects it opens ---------------------------------------------------------- Key: DERBY-2229 URL: https://issues.apache.org/jira/browse/DERBY-2229 Project: Derby Issue Type: Bug Components: Test Affects Versions: 10.3.0.0 Reporter: Daniel John Debrunner Priority: Minor The comment at the end of connectionWorkhorse is: // No need to close the objects. They were closed by vetObject(). but if I add an assert after that comment the test fails: assertTrue(conn.isClosed()); (around line 495) I don't see the close() methods being added to the list of methods to check though it's hard to follow the code, seems like it might be more obvious just to call the close methods rather than trying to force them into the inspection phase, especially as a specific sort is needed. Do the close() methods need to be tested as part of the inspection/vetting phase? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira