db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Knut Anders Hatlen <Knut.Hat...@Sun.COM>
Subject Re: [jira] Commented: (DERBY-2226) Move column bitset computation to IndexToBaseRowNode
Date Wed, 10 Jan 2007 15:33:14 GMT
"Dyre Tjeldvoll (JIRA)" <jira@apache.org> writes:

>     [ https://issues.apache.org/jira/browse/DERBY-2226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12463542
] 
>
> Dyre Tjeldvoll commented on DERBY-2226:
> ---------------------------------------
>
> I have attached a patch derby-2226.v1 for this issue.
> Derbyall and Junit tests pass.
>
> Please review.

Hi Dyre,

I had a quick look at the patch, and there was one thing I didn't
quite understand in IndexToBaseRowNode.init(). When heapReferencedCols
is null, allReferencedCols is also set to null. Intuitively, I would
say allReferencedCols should be equal to indexReferencedCols in that
case (since A U NULL == A). Or maybe indexReferencedCols is always
null when heapReferencedCols is null?

Also, in the same method, is the "return" necessary? If it isn't, I
think it would be better to remove it since it could easily be
overlooked by someone who adds more code below the if-block later.

-- 
Knut Anders

Mime
View raw message