db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Knut Anders Hatlen (JIRA)" <j...@apache.org>
Subject [jira] Commented: (DERBY-2191) Cleanup of FormatableBitSet
Date Wed, 17 Jan 2007 11:02:27 GMT

    [ https://issues.apache.org/jira/browse/DERBY-2191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12465418
] 

Knut Anders Hatlen commented on DERBY-2191:
-------------------------------------------

When I looked at the previous patches, I noticed some other minor issues that could be fixed
in FormatableBitSet. The proposed changes are attached as cleanup2191.diff:

* Remove unused import java.io.InputStream.
* numBytesFromBits() is unnecessarily complex. Currently, it returns (bits == 0) ? 0 : ((bits
- 1) / 8) + 1, but for non-negative values of bits, (bits + 7) >> 3 gives the same results
(and bits should never be negative).
* Remove unused variables in toString().

> Cleanup of FormatableBitSet
> ---------------------------
>
>                 Key: DERBY-2191
>                 URL: https://issues.apache.org/jira/browse/DERBY-2191
>             Project: Derby
>          Issue Type: Improvement
>          Components: Miscellaneous
>    Affects Versions: 10.2.1.6
>            Reporter: Dyre Tjeldvoll
>         Assigned To: Dyre Tjeldvoll
>            Priority: Trivial
>             Fix For: 10.3.0.0
>
>         Attachments: cleanup2191.diff, cleanup2191.stat, deadcode.v1.diff, deadcode.v2.diff,
fbstst.v1.diff, fbstst.v1.stat, FormatableBitSetTest.java, valuenotnull.v1.diff, valuenotnull.v1.stat
>
>
> The implementation of FormatableBitSet could be streamlined. Dead code can be removed
and the implementation of some methods can be simplified.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message