db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bryan Pendleton (JIRA)" <j...@apache.org>
Subject [jira] Commented: (DERBY-2191) Cleanup of FormatableBitSet
Date Tue, 30 Jan 2007 17:46:33 GMT

    [ https://issues.apache.org/jira/browse/DERBY-2191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12468708
] 

Bryan Pendleton commented on DERBY-2191:
----------------------------------------

> there is an asymmetry between grow(int) and shrink(int)

Would it make sense to collapse grow() and shrink() into a single method,
perhaps called something like "setBitSize()" or "setCapacity"? It might make
it more clear at the caller's level that it doesn't matter whether you are
making the bitset larger or smaller; you just need to specify the new size.


> Cleanup of FormatableBitSet
> ---------------------------
>
>                 Key: DERBY-2191
>                 URL: https://issues.apache.org/jira/browse/DERBY-2191
>             Project: Derby
>          Issue Type: Improvement
>          Components: Miscellaneous
>    Affects Versions: 10.2.1.6
>            Reporter: Dyre Tjeldvoll
>         Assigned To: Dyre Tjeldvoll
>            Priority: Trivial
>             Fix For: 10.3.0.0
>
>         Attachments: anysetbit.v1.diff, anysetbit.v1.stat, anysetbit.v2.diff, bitops.v1.diff,
bitops.v1.stat, bitops.v2.diff, bitops.v2.stat, bitops.v3.diff, bitopt.v1.diff, bitopt.v1.stat,
bitopt.v2.diff, boundarycheck.v1.diff, boundarycheck.v1.stat, cleanup2191.diff, cleanup2191.stat,
deadcode.v1.diff, deadcode.v2.diff, fbstst.v1.diff, fbstst.v1.stat, FormatableBitSetTest.java,
numbitsset.v1.diff, numbitsset.v1.stat, numbitsset.v2.diff, numbitstest.diff, shrink.v1.diff,
shrink.v1.stat, unusedmethods.v1.diff, unusedmethods.v1.stat, valuenotnull.v1.diff, valuenotnull.v1.stat
>
>
> The implementation of FormatableBitSet could be streamlined. Dead code can be removed
and the implementation of some methods can be simplified.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message