db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Knut Anders Hatlen (JIRA)" <j...@apache.org>
Subject [jira] Commented: (DERBY-2191) Cleanup of FormatableBitSet
Date Mon, 29 Jan 2007 11:04:49 GMT

    [ https://issues.apache.org/jira/browse/DERBY-2191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12468230

Knut Anders Hatlen commented on DERBY-2191:

I have looked at anysetbit.v1 and numbitsset.v1. I think the changes look very good. And thank
you for documenting the algorithm used in getNumBitsSet() so thoroughly!

Some small comments:
  1) In anySetBits(), perhaps "return (umul8(i)|firstSet(v));" would be clearer if it used
plus instead of or?
  2) Since anySetBits() and getNumBitsSet() now use all bits in the last byte, maybe they
should start with "ASSERT(invariantHolds())"?
  3) I think it would be good if firstSet() had a short comment explaining what it's supposed
to do.
  4) Would it be better if the return statements in firstSet() didn't use hex format? Since
the returned values are positions and not bit patterns, I mean.

> Cleanup of FormatableBitSet
> ---------------------------
>                 Key: DERBY-2191
>                 URL: https://issues.apache.org/jira/browse/DERBY-2191
>             Project: Derby
>          Issue Type: Improvement
>          Components: Miscellaneous
>    Affects Versions:
>            Reporter: Dyre Tjeldvoll
>         Assigned To: Dyre Tjeldvoll
>            Priority: Trivial
>             Fix For:
>         Attachments: anysetbit.v1.diff, anysetbit.v1.stat, bitops.v1.diff, bitops.v1.stat,
bitops.v2.diff, bitops.v2.stat, bitops.v3.diff, bitopt.v1.diff, bitopt.v1.stat, bitopt.v2.diff,
boundarycheck.v1.diff, boundarycheck.v1.stat, cleanup2191.diff, cleanup2191.stat, deadcode.v1.diff,
deadcode.v2.diff, fbstst.v1.diff, fbstst.v1.stat, FormatableBitSetTest.java, numbitsset.v1.diff,
numbitsset.v1.stat, unusedmethods.v1.diff, unusedmethods.v1.stat, valuenotnull.v1.diff, valuenotnull.v1.stat
> The implementation of FormatableBitSet could be streamlined. Dead code can be removed
and the implementation of some methods can be simplified.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message