Return-Path: Delivered-To: apmail-db-derby-dev-archive@www.apache.org Received: (qmail 63200 invoked from network); 7 Dec 2006 13:43:23 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 7 Dec 2006 13:43:23 -0000 Received: (qmail 49769 invoked by uid 500); 7 Dec 2006 13:43:31 -0000 Delivered-To: apmail-db-derby-dev-archive@db.apache.org Received: (qmail 49740 invoked by uid 500); 7 Dec 2006 13:43:31 -0000 Mailing-List: contact derby-dev-help@db.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: Delivered-To: mailing list derby-dev@db.apache.org Received: (qmail 49731 invoked by uid 99); 7 Dec 2006 13:43:31 -0000 Received: from herse.apache.org (HELO herse.apache.org) (140.211.11.133) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 07 Dec 2006 05:43:30 -0800 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests=UNPARSEABLE_RELAY X-Spam-Check-By: apache.org Received-SPF: pass (herse.apache.org: local policy) Received: from [192.18.1.36] (HELO gmp-ea-fw-1.sun.com) (192.18.1.36) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 07 Dec 2006 05:43:19 -0800 Received: from d1-emea-09.sun.com ([192.18.2.119]) by gmp-ea-fw-1.sun.com (8.13.6+Sun/8.12.9) with ESMTP id kB7Dgt7f007872 for ; Thu, 7 Dec 2006 13:42:57 GMT Received: from conversion-daemon.d1-emea-09.sun.com by d1-emea-09.sun.com (Sun Java System Messaging Server 6.2-6.01 (built Apr 3 2006)) id <0J9W00A01OR6TT00@d1-emea-09.sun.com> (original mail from Knut.Hatlen@Sun.COM) for derby-dev@db.apache.org; Thu, 07 Dec 2006 13:42:55 +0000 (GMT) Received: from localhost ([129.159.112.231]) by d1-emea-09.sun.com (Sun Java System Messaging Server 6.2-6.01 (built Apr 3 2006)) with ESMTPSA id <0J9W00M50ORI0R3V@d1-emea-09.sun.com> for derby-dev@db.apache.org; Thu, 07 Dec 2006 13:42:55 +0000 (GMT) Date: Thu, 07 Dec 2006 14:42:54 +0100 From: Knut Anders Hatlen Subject: Re: [jira] Commented: (DERBY-1471) Implement layer B streaming for new methods defined in JDBC4.0 In-reply-to: <4577FC41.4010905@basil.ocn.ne.jp> Sender: Knut.Hatlen@Sun.COM To: derby-dev@db.apache.org Message-id: Organization: Sun Microsystems MIME-version: 1.0 Content-type: text/plain; charset=us-ascii Content-transfer-encoding: 7BIT References: <24636914.1165419263801.JavaMail.jira@brutus> <4577FC41.4010905@basil.ocn.ne.jp> User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/22.0.91 (usg-unix-v) X-Virus-Checked: Checked by ClamAV on apache.org TomohitoNakayama writes: > Thank you for your attention. > > I think another patch is needed before committing ... Thank you for taking my comments into consideration. >>* Blob/Clob: The variable willBeLayerBStreamed_ and the method >> willBeLayerBStreamed() could be moved to the base class (Lob) to >> avoid duplicated code. >> > I am somewhat repulsed for sharing code around instance variable .... > > However, the value never be changed in the life of the object and > they are equal in semantics .... In that case I think it would be good to declare the variable as final as well. Seems like it is initialized in the constructor and is newer changed, so that should work. -- Knut Anders