Return-Path: Delivered-To: apmail-db-derby-dev-archive@www.apache.org Received: (qmail 81445 invoked from network); 4 Dec 2006 19:58:12 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 4 Dec 2006 19:58:12 -0000 Received: (qmail 52318 invoked by uid 500); 4 Dec 2006 19:58:21 -0000 Delivered-To: apmail-db-derby-dev-archive@db.apache.org Received: (qmail 52274 invoked by uid 500); 4 Dec 2006 19:58:20 -0000 Mailing-List: contact derby-dev-help@db.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: Delivered-To: mailing list derby-dev@db.apache.org Received: (qmail 52265 invoked by uid 99); 4 Dec 2006 19:58:20 -0000 Received: from herse.apache.org (HELO herse.apache.org) (140.211.11.133) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 04 Dec 2006 11:58:20 -0800 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (herse.apache.org: domain of mcintyre.a@gmail.com designates 64.233.184.238 as permitted sender) Received: from [64.233.184.238] (HELO wr-out-0506.google.com) (64.233.184.238) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 04 Dec 2006 11:58:09 -0800 Received: by wr-out-0506.google.com with SMTP id i2so1484542wra for ; Mon, 04 Dec 2006 11:57:49 -0800 (PST) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=VvSlS63Ax1eA5InziOgBnMnmD5cLOY6lGzotmuZq5kQR5qW8oiXV4IZQcLXmPg4Jn0A+KV6AEaQot32bMLmZ9kkW8mo8yIgHwYYhzcC/cQzmBHKZ6ab4RKghjVLrvNsBzDTeHOwPQZeLKJNb1+bZhnsyiRukim0v8TtmCAPbAoM= Received: by 10.78.185.16 with SMTP id i16mr8056519huf.1165262267416; Mon, 04 Dec 2006 11:57:47 -0800 (PST) Received: by 10.78.138.15 with HTTP; Mon, 4 Dec 2006 11:57:47 -0800 (PST) Message-ID: <54ac72d70612041157k337bf5c5jc468e24211bc8206@mail.gmail.com> Date: Mon, 4 Dec 2006 11:57:47 -0800 From: "Andrew McIntyre" To: derby-dev@db.apache.org, jta@bristowhill.com Subject: Re: Re: Questions about committing doc patches In-Reply-To: <45747BBD.8000902@bristowhill.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <9f40b500612041123m1f658936h5a805d6a67738cb5@mail.gmail.com> <54ac72d70612041145k60bb8875x1b325eaebf4c99ae@mail.gmail.com> <45747BBD.8000902@bristowhill.com> X-Virus-Checked: Checked by ClamAV on apache.org On 12/4/06, Jean T. Anderson wrote: > Andrew McIntyre wrote: > > On 12/4/06, Laura Stewart wrote: > ... > >> Step 3 > >> If your machine is a different architecture from the machine on which > >> the patch was created, convert the file. > >> > >> Question - Aren't all patch files diff files? How will I know that the > >> patch was created on a different machine? I use Windows, what should > >> I look for to know that the patch was created in UNIX? Is the syntax: > >> unix2dos patch.diff or unix2dos > patch.diff ? > > > > I think step 3 should be removed. All patch files will be unified > > format diff files, as output by svn diff. Any patch program should be > > able to compensate for line-ending differences, since presumably on > > Windows you'll be using Cygwin's patch program. So, there should never > > be a need to convert the line-endings in the file. > > > > I get errors on Linux if I don't convert the file. You don't have this > problem? Nope, I get: patching file path/to/file (Stripping trailing CRs from patch.) with GNU patch v2.5.8. andrew