Return-Path: Delivered-To: apmail-db-derby-dev-archive@www.apache.org Received: (qmail 49017 invoked from network); 16 Dec 2006 17:07:44 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 16 Dec 2006 17:07:44 -0000 Received: (qmail 9999 invoked by uid 500); 16 Dec 2006 17:07:52 -0000 Delivered-To: apmail-db-derby-dev-archive@db.apache.org Received: (qmail 9772 invoked by uid 500); 16 Dec 2006 17:07:50 -0000 Mailing-List: contact derby-dev-help@db.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: Delivered-To: mailing list derby-dev@db.apache.org Received: (qmail 9763 invoked by uid 99); 16 Dec 2006 17:07:50 -0000 Received: from herse.apache.org (HELO herse.apache.org) (140.211.11.133) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 16 Dec 2006 09:07:50 -0800 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO brutus.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 16 Dec 2006 09:07:42 -0800 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 551E5714168 for ; Sat, 16 Dec 2006 09:07:22 -0800 (PST) Message-ID: <30361305.1166288842346.JavaMail.jira@brutus> Date: Sat, 16 Dec 2006 09:07:22 -0800 (PST) From: "Bryan Pendleton (JIRA)" To: derby-dev@db.apache.org Subject: [jira] Commented: (DERBY-2031) Convert derbynet/testProtocol.java to JUnit In-Reply-To: <12104694.1162486458063.JavaMail.root@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org [ http://issues.apache.org/jira/browse/DERBY-2031?page=comments#action_12459049 ] Bryan Pendleton commented on DERBY-2031: ---------------------------------------- It seems undesirable to have to change the visibility of the actual code. I remember that we've had some similar discussions on the mailing list recently. For example, http://www.nabble.com/Re%3A-JUnit-unit-tests---parallel-test-three--p5711307.html Unfortunately, I can't remember what we decided was the best technique for situations such as yours. > Convert derbynet/testProtocol.java to JUnit > ------------------------------------------- > > Key: DERBY-2031 > URL: http://issues.apache.org/jira/browse/DERBY-2031 > Project: Derby > Issue Type: Improvement > Components: Network Server, Test > Affects Versions: 10.3.0.0 > Reporter: Knut Anders Hatlen > Assigned To: Julius Stroffek > Priority: Minor > Attachments: d2031.diff, d2031.stat > > > testProtocol.java executes DRDA commands from a file written in a special-purpose language. The statements are very much like assertions, so it should be fairly easy to convert the test to JUnit. > Suggested approach: Change the interpreter (TestProto.java) so that is uses Assert.fail() instead of System.err.println() and System.exit(), and BaseTestCase.println() instead of System.out.println(). It should also use TestConfiguration to get the host name and port number. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira