db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Suresh Thalamati (JIRA)" <j...@apache.org>
Subject [jira] Commented: (DERBY-606) SYSCS_UTIL.SYSCS_INPLACE_COMPRESS_TABLE fails on (very) large tables
Date Wed, 06 Dec 2006 23:31:24 GMT
    [ http://issues.apache.org/jira/browse/DERBY-606?page=comments#action_12456260 ] 
            
Suresh Thalamati commented on DERBY-606:
----------------------------------------

derby606_impl-v5.diff :

This patch looks good to be committed. Did you run the regression tests ?
For some reason I can not apply this patch to my code-line.  
Could you please recreate the patch and post it. 


$ patch -i c:/temp/derby606_impl-v5.diff
patching file `java/engine/org/apache/derby/impl/store/raw/xact/Xact.java'
patching file `java/engine/org/apache/derby/impl/store/raw/data/CompressSpacePag
eOperation10_2.java'
patch: **** malformed patch at line 120: Index: java/engine/org/apache/derby/imp
l/store/raw/data/LoggableAllocActions.java


1) One minor thing I noticed is you did not update the MAX_ID_2 in the
following file :

Index: java/engine/org/apache/derby/iapi/services/io/StoredFormatIds.java

public static final int MAX_ID_2 =
                (MIN_ID_2 + 464);


File  derby606_upgrade-v5.diff :
--------------------------------

As Bryan and others pointed out Derby supports upgrade from 10.1 to 10.3
also. This patch seems to incorrectly remove 10.1 to 10.3 upgrade test.

After your latest change to allow Compress on softupgrade , following error
check  is not valid any more:

+			try {
+				checkDataToCase606(conn, 0, 104000, true);
+			} catch(SQLException sqle) {
+				passed = isExpectedException(sqle, "XSLB1");

Now the above check  is going to fail on softupgrade because of the derby-606 bug. 

As I understand changes to upgrade is going to test :

1) Compress Log Record writes on compress operation.
2) On hard upgrade , derby-606 problem does not occur. 

Following cases is not tested : 
1) Replay of the old compress log record  on softupgrade/hardupgrade (
readExternal() execution), because database is shutdown after each upgrade test
phase. This might be tricky to do because you need to simulate crash-recovery, 
you can work on it separately if you are interested. Let's try to get the 
current patches committed.     


Thanks
-suresh

> SYSCS_UTIL.SYSCS_INPLACE_COMPRESS_TABLE fails on (very) large tables
> --------------------------------------------------------------------
>
>                 Key: DERBY-606
>                 URL: http://issues.apache.org/jira/browse/DERBY-606
>             Project: Derby
>          Issue Type: Bug
>          Components: Store
>    Affects Versions: 10.1.1.0
>         Environment: Java 1.5.0_04 on Windows Server 2003 Web Edition
>            Reporter: Jeffrey Aguilera
>         Assigned To: Mayuresh Nirhali
>             Fix For: 10.3.0.0
>
>         Attachments: A606Test.java, derby606-v2.diff, derby606-v3.diff, derby606_impl-v4.diff,
derby606_impl-v5.diff, derby606_upgrade-v4.diff, derby606_upgrade-v5.diff, derby606_v1.diff
>
>
> SYSCS_UTIL.SYSCS_INPLACE_COMPRESS_TABLE fails with one of the following error messages
when applied to a very large table (>2GB):
> Log operation null encounters error writing itself out to the log stream, this could
be caused by an errant log operation or internal log buffer full due to excessively large
log operation. SQLSTATE: XJ001: Java exception: ': java.io.IOException'.
> or
> The exception 'java.lang.ArrayIndexOutOfBoundsException' was thrown while evaluating
an expression. SQLSTATE: XJ001: Java exception: ': java.lang.ArrayIndexOutOfBoundsException'.
> In either case, no entry is written to the console log or to derby.log.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message