db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Daniel John Debrunner <...@apache.org>
Subject Re: [jira] Commented: (DERBY-2109) System privileges
Date Mon, 11 Dec 2006 22:51:44 GMT
David Van Couvering (JIRA) wrote:
>     [ http://issues.apache.org/jira/browse/DERBY-2109?page=comments#action_12457499 ]

>             
> David Van Couvering commented on DERBY-2109:
> --------------------------------------------
> 
> Hi, Rick, nicely done!  Here are my comments:
> 
> - I like the use of Java security for system privileges
> - I think the system-wide permissions defined in the DerbyPermissions class can be a
little more descriptive, so that they are clear without having to refer to documentation:
>     o "create-plugin" rather than just "plugin"
>     o "shutdown-engine" rather than just "shutdown" (could be confused with permission
to shut down a db)
>     o "create-database" rather than just "create" (create what?)

I agree the names should be more descriptive, but just to note the 
convention is for the names to be camel-case java style, e.g.

   shutdownEngine
   createDatabase

I also think the permissions should not be in the o.a.d.authentication 
package since they do not implement authentication in any way. My 
original suggestion had o.a.d.security as the package.

Dan.


Mime
View raw message