Return-Path: Delivered-To: apmail-db-derby-dev-archive@www.apache.org Received: (qmail 84527 invoked from network); 6 Nov 2006 17:57:59 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 6 Nov 2006 17:57:59 -0000 Received: (qmail 37099 invoked by uid 500); 6 Nov 2006 17:58:10 -0000 Delivered-To: apmail-db-derby-dev-archive@db.apache.org Received: (qmail 36887 invoked by uid 500); 6 Nov 2006 17:58:10 -0000 Mailing-List: contact derby-dev-help@db.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: Delivered-To: mailing list derby-dev@db.apache.org Received: (qmail 36878 invoked by uid 99); 6 Nov 2006 17:58:10 -0000 Received: from herse.apache.org (HELO herse.apache.org) (140.211.11.133) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 06 Nov 2006 09:58:10 -0800 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO brutus.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 06 Nov 2006 09:57:58 -0800 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 3713D71430E for ; Mon, 6 Nov 2006 09:57:38 -0800 (PST) Message-ID: <6335327.1162835858222.JavaMail.jira@brutus> Date: Mon, 6 Nov 2006 09:57:38 -0800 (PST) From: "Knut Anders Hatlen (JIRA)" To: derby-dev@db.apache.org Subject: [jira] Commented: (DERBY-2047) TestDataSourceFactory doesn't work correctly outside the old harness In-Reply-To: <6762714.1162663216478.JavaMail.root@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org [ http://issues.apache.org/jira/browse/DERBY-2047?page=comments#action_12447484 ] Knut Anders Hatlen commented on DERBY-2047: ------------------------------------------- Thanks Dan, I hadn't noticed your comment about this problem under DERBY-2043. Your approach sounds cleaner to me. Feel free to take over the issue and continue as you had planned. There is at least one problem with my patch. JDBCClient.getDataSourceClassName() doesn't return the correct name for JSR169, so BaseJDBCTestCase.getConnection() won't work under JSR169. Should be easy to fix, though. I think the changes I made to JDBCClient will be useful for your approach too. > TestDataSourceFactory doesn't work correctly outside the old harness > -------------------------------------------------------------------- > > Key: DERBY-2047 > URL: http://issues.apache.org/jira/browse/DERBY-2047 > Project: Derby > Issue Type: Bug > Components: Test > Affects Versions: 10.3.0.0 > Reporter: Knut Anders Hatlen > Assigned To: Knut Anders Hatlen > Attachments: DataSource.java, derby-2047.diff, derby-2047.stat > > > TestDataSourceFactory uses TestUtil to create DataSource, ConnectionPoolDataSource and XADataSource objects. TestUtil needs to run in the old harness in order to detect which framework it is running under, so it will create embedded data sources for all JUnit tests that are run outside the old harness. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira