Return-Path: Delivered-To: apmail-db-derby-dev-archive@www.apache.org Received: (qmail 82160 invoked from network); 23 Nov 2006 11:30:47 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 23 Nov 2006 11:30:47 -0000 Received: (qmail 1687 invoked by uid 500); 23 Nov 2006 11:30:57 -0000 Delivered-To: apmail-db-derby-dev-archive@db.apache.org Received: (qmail 1476 invoked by uid 500); 23 Nov 2006 11:30:56 -0000 Mailing-List: contact derby-dev-help@db.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: Delivered-To: mailing list derby-dev@db.apache.org Received: (qmail 1467 invoked by uid 99); 23 Nov 2006 11:30:56 -0000 Received: from herse.apache.org (HELO herse.apache.org) (140.211.11.133) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 23 Nov 2006 03:30:56 -0800 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (herse.apache.org: domain of tomonaka@basil.ocn.ne.jp designates 222.146.51.83 as permitted sender) Received: from [222.146.51.83] (HELO smtp.basil.ocn.ne.jp) (222.146.51.83) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 23 Nov 2006 03:30:43 -0800 Received: from [192.168.0.8] (p18208-adsah09honb5-acca.tokyo.ocn.ne.jp [219.161.98.208]) by smtp.basil.ocn.ne.jp (Postfix) with ESMTP id 1426B71B8 for ; Thu, 23 Nov 2006 20:30:20 +0900 (JST) Received: from 127.0.0.1 (AVG SMTP 7.5.431 [268.14.14/547]); Thu, 23 Nov 2006 20:31:57 +0900 Message-ID: <456586A8.90805@basil.ocn.ne.jp> Date: Thu, 23 Nov 2006 20:31:52 +0900 From: TomohitoNakayama User-Agent: Mozilla Thunderbird 1.0.7 (Windows/20050923) X-Accept-Language: ja, en-us, en MIME-Version: 1.0 To: derby-dev@db.apache.org Subject: Re: [jira] Updated: (DERBY-1471) Implement layer B streaming for new methods defined in JDBC4.0 References: <6934032.1164245163180.JavaMail.jira@brutus> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org Hello Knut. Sorry. I misunderstood about your previous mail .... I will correct casting to EmbedXXX as to EngineXXX ... // I took them by mistake because I tought correct module have lengthless method already ... A modification of message properies is needed too . Best regards. Knut Anders Hatlen wrote: >"Tomohito Nakayama (JIRA)" writes: > > > >>I submit the patch for DERBY-1471. >> >>* Description of the patch >> * This patch implements Layer B streaming for new methods defined in JDBC4.0 as next. >> * Derby NetClient sends lengthless LOB information in Layer B streaming. >> * Derby NetworkServer receives LOB information sent via Layer B streaming. >> >> > >Hi Tomohito, > >I haven't looked at the details of your implementation, but I have one >comment regarding the casting to EmbedPreparedStatement in >DRDAConnThread. I think the network server should avoid using the >EmbedXXX classes directly and use EngineXXX instead. DERBY-1015 was >logged to replace all EmbedXXX casts with EngineXXX cast, and its >description suggests that the objects can be BrokeredPreparedStatement >objects in some cases. > >It would also be good if the lines in the source files did not exceed >80 characters, as many of us read the code in windows that are 80 >characters wide. > >I noticed a new SQLState (XJ216) in the patch, but I can't see that >there's a message for it. > >Thanks, > > > -- /* Tomohito Nakayama tomonaka@basil.ocn.ne.jp tomohito@rose.zero.ad.jp tmnk@apache.org Naka http://www5.ocn.ne.jp/~tomohito/TopPage.html */