db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From TomohitoNakayama <tomon...@basil.ocn.ne.jp>
Subject Re: [jira] Updated: (DERBY-1471) Implement layer B streaming for new methods defined in JDBC4.0
Date Thu, 23 Nov 2006 11:31:52 GMT
Hello Knut.

Sorry.
I misunderstood about your previous mail ....
I will correct casting to EmbedXXX as to EngineXXX ...

// I took them by mistake because I tought correct module have 
lengthless method already ...

A modification of message properies is needed too .

Best regards.


Knut Anders Hatlen wrote:

>"Tomohito Nakayama (JIRA)" <jira@apache.org> writes:
>
>  
>
>>I submit the patch for DERBY-1471.
>>
>>* Description of the patch
>>   * This patch implements Layer B streaming for new methods defined in JDBC4.0 as
next.
>>      * Derby NetClient sends lengthless LOB information in Layer B streaming.
>>      * Derby NetworkServer receives LOB information sent via Layer B streaming.
>>    
>>
>
>Hi Tomohito,
>
>I haven't looked at the details of your implementation, but I have one
>comment regarding the casting to EmbedPreparedStatement in
>DRDAConnThread. I think the network server should avoid using the
>EmbedXXX classes directly and use EngineXXX instead. DERBY-1015 was
>logged to replace all EmbedXXX casts with EngineXXX cast, and its
>description suggests that the objects can be BrokeredPreparedStatement
>objects in some cases.
>
>It would also be good if the lines in the source files did not exceed
>80 characters, as many of us read the code in windows that are 80
>characters wide.
>
>I noticed a new SQLState (XJ216) in the patch, but I can't see that
>there's a message for it.
>
>Thanks,
>
>  
>

-- 
/*

        Tomohito Nakayama
        tomonaka@basil.ocn.ne.jp
        tomohito@rose.zero.ad.jp
        tmnk@apache.org

        Naka
        http://www5.ocn.ne.jp/~tomohito/TopPage.html

*/ 


Mime
View raw message