db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bryan Pendleton (JIRA)" <j...@apache.org>
Subject [jira] Updated: (DERBY-1490) Provide ALTER TABLE RENAME COLUMN functionality
Date Fri, 03 Nov 2006 23:58:18 GMT
     [ http://issues.apache.org/jira/browse/DERBY-1490?page=all ]

Bryan Pendleton updated DERBY-1490:
-----------------------------------

    Attachment: renameColumn_v3_after_review.diff

Attached is renameColumn_v3_after_reviews.diff, an updated patch proposal.

Thank you very much to all the reviewers; the comments were very helpful!

The major difference between this patch and the previous one is that this patch
includes only the RENAME COLUMN statement. The consensus seemed to be
that there was no need to provide two statements that did the same thing, and
the RENAME COLUMN statement feels more natural.

I filed two issues for follow-on analysis:
 - DERBY-2041, to track the unexpected behavior I saw with triggers, 
 - DERBY-2041, to track the need for updating documentation to describe the new features.

The updated patch also includes several new tests as suggested by the reviewers,
and addresses some whitespace and formatting problems caused by the fact
that my default editor setup uses spaces, not tabs, while the sqlgrammar.jj file
is still largely tab-based, so tab-based patches are preferable.

The patch is updated to a recent trunk, so should apply cleanly.

Reviewers, could you please let me know what you think of this latest patch? Thanks!

> Provide ALTER TABLE RENAME COLUMN functionality
> -----------------------------------------------
>
>                 Key: DERBY-1490
>                 URL: http://issues.apache.org/jira/browse/DERBY-1490
>             Project: Derby
>          Issue Type: New Feature
>          Components: Documentation, SQL
>    Affects Versions: 10.0.2.0, 10.0.2.1, 10.1.1.0, 10.2.1.6, 10.1.2.1, 10.1.3.1
>            Reporter: Bryan Pendleton
>         Assigned To: Bryan Pendleton
>         Attachments: 1490_cannot_patch.jpg, derby1490_v1_needMoreTests.diff, renameColumn_v2_with_tests.diff,
renameColumn_v3_after_review.diff
>
>
> Provide a way to rename a column in an existing table. Possible syntax could be:
>   ALTER TABLE tablename RENAME COLUMN oldcolumn TO newcolumn;
> Feature should properly handle the possibility that the column is currently used in constraints,
views, indexes, triggers, etc.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message