db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Knut Anders Hatlen (JIRA)" <j...@apache.org>
Subject [jira] Commented: (DERBY-2102) JDBC.assertFullResultSet should handle byte arrays
Date Mon, 20 Nov 2006 22:46:04 GMT
    [ http://issues.apache.org/jira/browse/DERBY-2102?page=comments#action_12451464 ] 
            
Knut Anders Hatlen commented on DERBY-2102:
-------------------------------------------

If either the expected or the actual value is null, and the assert fails, won't this part
throw a NullPointerException?

+                } else {
+                    expected = expectedRow[i].toString();
+                    found = obj.toString();
+                }

Perhaps expected and found could be declared as Objects instead of Strings?

Minor nits: Please use StringBuffer instead of String in bytesToString(). :) And its javadoc
comment lacks one '*' in order to be proper javadoc.

> JDBC.assertFullResultSet should handle byte arrays
> --------------------------------------------------
>
>                 Key: DERBY-2102
>                 URL: http://issues.apache.org/jira/browse/DERBY-2102
>             Project: Derby
>          Issue Type: Improvement
>          Components: Test
>    Affects Versions: 10.3.0.0
>            Reporter: Øystein Grøvlen
>         Assigned To: Øystein Grøvlen
>            Priority: Trivial
>             Fix For: 10.3.0.0
>
>         Attachments: derby2102.diff
>
>
> Currently, JDBC.assertFullResultset() cannot be used for columns that maps to byte[]
(e.g., CHAR FOR BIT DATA).
> To support this, assertRowInResultSet need to be extended the case where the column object
is a byte[].

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

Mime
View raw message