db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Knut Anders Hatlen (JIRA)" <j...@apache.org>
Subject [jira] Commented: (DERBY-2110) message typos: error 42X52, XJ100.S, XBCXU/XBCXV...
Date Mon, 27 Nov 2006 07:57:22 GMT
    [ http://issues.apache.org/jira/browse/DERBY-2110?page=comments#action_12453522 ] 
            
Knut Anders Hatlen commented on DERBY-2110:
-------------------------------------------

I think the message means that there is a mix of LF and CR-LF in the file. You could try to
run a dos2unix tool and see if it that will make it work.

There is one part of the diff I don't understand:

@@ -1,7 +1,8 @@

 <?xml version="1.0" encoding="utf-8"?>
 <!DOCTYPE reference PUBLIC "-//OASIS//DTD DITA Reference//EN"
- "../dtd/reference.dtd">
-<reference id="rrefexcept71493" xml:lang="en-us">
+ "../../derby/docs/trunk/src/dtd/reference.dtd">
+
+<reference id="rrefexcept71493" xml:lang="en-us" >
 <!-- 
 Licensed to the Apache Software Foundation (ASF) under one or more
 contributor license agreements.  See the NOTICE file distributed with

Doesn't this add a requirement that the sources are checked out in a specific directory?

The rest of the patch is difficult to read because most of the lines in the file have been
reformatted, but I guess that's OK since the file is auto-generated.

I think it would be good if patches were uploaded before/when they were committed. Even though
it's possible to fetch the diffs from the subversion history, attaching the patch to the issue
makes it more likely that someone will review the changes. The more eyes the better...

> message typos: error 42X52, XJ100.S, XBCXU/XBCXV...
> ---------------------------------------------------
>
>                 Key: DERBY-2110
>                 URL: http://issues.apache.org/jira/browse/DERBY-2110
>             Project: Derby
>          Issue Type: Bug
>          Components: Localization
>    Affects Versions: 10.2.1.6, 10.3.0.0
>            Reporter: Myrna van Lunteren
>         Assigned To: Myrna van Lunteren
>            Priority: Trivial
>         Attachments: DERBY-2110_20061126.diff, rrefexcept71493.dita, rrefexcept71493.html
>
>
> There are some minor typos and issues in the English error messages files:
> engine messages:
> - 42X52 - message has this: 
>     ' '{0}" (single quote - single quote - curly brace open - zero - curly brace close
- double quote)
>   should be two closing single quotes.
> - XJ100.S has a stray double quote at the end
> - XBCXU and XBCXV will get a double period in 'real live', for instance:
>    ERROR XBCXU: Encryption of an un-encrypted database failed: Container was opened in
read-only mode.   .
>    ERROR XBCXU: Encryption of an un-encrypted database with a new key or a new password
failed: Container was opened in read-only mode.   .
>         Either the period/full stop at the end of the parameter string, or at the end
of the 'parent' string will need to be removed.
> And this is what my spell/grammar checker complained about:
> - 42X46, 42X47 has a grammar issue: "Use a the full signature" should be "Use the full
signature"
> - 42X69: 'expresssion' has 3 s-es.
> - 58009.C.21, 7, 8 - DRDA codes should probably be in uppercase.
> - XBM08.D - 'instantiage' should be 'instantiate'
> - XSCB4.S - 'ie.' should be 'i.e.'
> - XSDF2.S - 'exeception' should be 'exception'
> - XSLAL.D - 'encounted' should be 'encountered'
> - XSTB6.M - 'substitue' should be 'substitute'
> - 42Z54.U - 'excepiton' should be 'exception'
> - C001 - 'A unknown' should be 'An unknown'
> - L008, L009 - 'Deleteing' should be 'Deleting'
> servlet_en.messages:
> SRV_MaxTrys - 'trys' should be 'tries'

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message