db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Knut Anders Hatlen (JIRA)" <j...@apache.org>
Subject [jira] Commented: (DERBY-2050) Manipulating CachedItems could be more efficient
Date Wed, 08 Nov 2006 14:50:52 GMT
    [ http://issues.apache.org/jira/browse/DERBY-2050?page=comments#action_12448155 ] 
            
Knut Anders Hatlen commented on DERBY-2050:
-------------------------------------------

I haven't tested the performance impact, but I definitely think the patch makes the code cleaner.
A couple of small comments:
  * The final keyword has been removed from the definition of isKept() and isValid(). Was
that intentional?
  * The comment in settingIdentityComplete() was deleted, but I think it's still relevant.
  * White-space changes in unkeep() and use(). Blanks inserted in front of the tabs.

> Manipulating CachedItems could be more efficient
> ------------------------------------------------
>
>                 Key: DERBY-2050
>                 URL: http://issues.apache.org/jira/browse/DERBY-2050
>             Project: Derby
>          Issue Type: Improvement
>          Components: Performance
>    Affects Versions: 10.2.1.6
>            Reporter: Dyre Tjeldvoll
>            Priority: Trivial
>             Fix For: 10.3.0.0
>
>         Attachments: derby-2050.diff, derby-2050.stat
>
>
> CachedItem's state is currently recorded in bit fields of an integer variable. Changing
this to 6 boolean member variables reduces cpu usage. 

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message