db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Knut Anders Hatlen (JIRA)" <j...@apache.org>
Subject [jira] Commented: (DERBY-1434) Client can send incorrect database name to server after having made multiple connections to different databases.
Date Wed, 22 Nov 2006 23:47:06 GMT
    [ http://issues.apache.org/jira/browse/DERBY-1434?page=comments#action_12452082 ] 
Knut Anders Hatlen commented on DERBY-1434:

Hi Julo,

I haven't followed the discussion about this bug closely enough to say
whether the fix is correct, but it looks like it follows the approach
which was suggested in the discussion. The changes to the protocol
test also seem to be correct.

A couple of questions/comments:

 - DRDAConnThread checks the version of the client. Is the check
   correct? Shouldn't the condition be
     (appRequester.getClientType() == AppRequester.DNC_CLIENT
       && appRequester.greaterThanOrEqualTo(10,3,0)) ?

 - The class name in the copyright header in DRDAProtocolTest is wrong
   ("lang" should be "derbynet").

 - I think it would be good if the test case in DRDAProtocolTest had a
   comment which described what it is testing. Is it supposed to fail
   without the fix? In my environment it runs successfully even when
   the fix is not applied.

 - It seems like your editor is set up with tab stops at eight
   characters. The Derby code uses tab stops at four characters, so
   the indentation does not match the indentation of the surrounding
   code. It would be good if you changed your tab settings and fixed
   the indentation.


> Client can send incorrect database name to server after having made multiple connections
to different databases.
> ----------------------------------------------------------------------------------------------------------------
>                 Key: DERBY-1434
>                 URL: http://issues.apache.org/jira/browse/DERBY-1434
>             Project: Derby
>          Issue Type: Bug
>          Components: Network Client
>    Affects Versions:,
>            Reporter: A B
>         Assigned To: Julius Stroffek
>             Fix For:
>         Attachments: _driver_1, d1434.java, d1434_v2.java, derby-1434-trunk-diff.txt,
derby1434-try2.diff, derby1434-try2.diff, derby1434-try2.stat, Server2.trace
> I have a simple program that connects to a database using the Derby Client, executes
a simple query, then connects to a different database using a different Connection object
and executes another simple query on that second connection.  The queries both execute without
error, so it appears that the connections are correct--i.e. each query will only work on one
of the databases, and both queries work, therefore each must be getting executed against the
correct database.
> But in looking at the client and server traces, I noticed that for the query on the second
database, the client is actually sending the name of the *first* database as RDBNAM, which
(I think?) is wrong--it should be sending the name of the second database, since the query
is being executed on the second Connection object.
> This behavior does not appear to occur for JCC.

This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira


View raw message