db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Daniel John Debrunner (JIRA)" <j...@apache.org>
Subject [jira] Created: (DERBY-2096) Change the Parser.parserStatement() to return the more specific StatementNode instead of QueryTreeNode.
Date Fri, 17 Nov 2006 17:52:45 GMT
Change the Parser.parserStatement() to return the more specific StatementNode instead of QueryTreeNode.
-------------------------------------------------------------------------------------------------------

                 Key: DERBY-2096
                 URL: http://issues.apache.org/jira/browse/DERBY-2096
             Project: Derby
          Issue Type: Improvement
          Components: SQL
            Reporter: Daniel John Debrunner
         Assigned To: Daniel John Debrunner
            Priority: Minor


Since this is compilinga statement returning the specific node makes more sense and will lead
to a little more clarity in the code.
Some of the methods defined on QueryTreeNode such as generate() and needsSavepoint() can move
down to StatementNode and thus make the code more readable ("which generate is called for
a value node?") and remove implementations of these methods that can never be called.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message